Summary: | Grammar fix in the manage_circ_rules_from_any_libraries description | ||
---|---|---|---|
Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
Component: | Patrons | Assignee: | Jasmine Amohia <jasmineamohia.student> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | david, fridolin.somers, gmcharlt, jasmineamohia.student, jesse, kyle.m.hall, martin.renvoize, nick |
Version: | unspecified | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 21930 | ||
Bug Blocks: | |||
Attachments: |
Bug 22149: Fixed grammar in the manage_circ_rules_from_any_libraries description
Bug 22149: Fixed grammar in the manage_circ_rules_from_any_libraries description Bug 22149: Fixed grammar in the manage_circ_rules_from_any_libraries description Bug 22149: Fixed grammar in the manage_circ_rules_from_any_libraries description |
Description
Aleisha Amohia
2019-01-16 23:01:26 UTC
Created attachment 84104 [details] [review] Bug 22149: Fixed grammar in the manage_circ_rules_from_any_libraries description Test plan: 1. Review patch and confirm that the sentence makes sense Hi Jasmine. After reviewing this I think it should be 'for' rather than 'from'. Also, the patch doesn't change the text. If you could redo with the new wording as follows: "Manage circulation rules for any library. If not set the logged in user can only edit circulation rules for their own library (please note that manage_circ_rules is still required)." David Created attachment 84153 [details] [review] Bug 22149: Fixed grammar in the manage_circ_rules_from_any_libraries description Test plan: 1. Review patch and confirm that the sentence makes sense Created attachment 84171 [details] [review] Bug 22149: Fixed grammar in the manage_circ_rules_from_any_libraries description Test plan: 1. Review patch and confirm that the sentence makes sense Signed-off-by: David Nind <david@davidnind.com> Thanks Jasmine! Created attachment 84237 [details] [review] Bug 22149: Fixed grammar in the manage_circ_rules_from_any_libraries description Test plan: 1. Review patch and confirm that the sentence makes sense Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.03 Pushed to 18.05.x for 18.05.09 I prefer not push to 17.11.x to avoid translation work |