Summary: | Library group description input field should be longer | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | System Administration | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Josef Moravec <josef.moravec> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, josef.moravec, lucas, martin.renvoize, nick, oleonard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 22170: Improve display of add/edit library group modal
Bug 22056: Remove remaining files in test directories Bug 22170: Improve display of add/edit library group modal Bug 22170: Improve display of add/edit library group modal Bug 22170: Improve display of add/edit library group modal |
Description
Katrin Fischer
2019-01-18 15:30:56 UTC
Created attachment 84936 [details] [review] Bug 22170: Improve display of add/edit library group modal Tries to bring the emodal for adding/editing library root and sub groups more in line with the rest of Koha. To test: - Go to Administration > Library groups - With and without patch test following actions: - Add a new root group - Edit root group - Add sub-group entry - Edit sub-group entry - Verify that with the patch the display of the labels is more standard (bold and aligned to the right) and the input fields are a bit longer to allow for easier data entry. I tried to copy parts of what Owen did recently with the 'Draw SQL charts' modal, hopefully it makes sense :) Created attachment 84937 [details] [review] Bug 22056: Remove remaining files in test directories It looks like these directories and test files were added by bug 5309. Later, most of the files were removed as no longer needed by bug 14321. Test: Verify that the files removed are no longer in use and can be safely removed. Created attachment 84972 [details] [review] Bug 22170: Improve display of add/edit library group modal Tries to bring the emodal for adding/editing library root and sub groups more in line with the rest of Koha. To test: - Go to Administration > Library groups - With and without patch test following actions: - Add a new root group - Edit root group - Add sub-group entry - Edit sub-group entry - Verify that with the patch the display of the labels is more standard (bold and aligned to the right) and the input fields are a bit longer to allow for easier data entry. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Comment on attachment 84937 [details] [review] Bug 22056: Remove remaining files in test directories Patch on wrong bug, will fix later! Created attachment 85192 [details] [review] Bug 22170: Improve display of add/edit library group modal Tries to bring the emodal for adding/editing library root and sub groups more in line with the rest of Koha. To test: - Go to Administration > Library groups - With and without patch test following actions: - Add a new root group - Edit root group - Add sub-group entry - Edit sub-group entry - Verify that with the patch the display of the labels is more standard (bold and aligned to the right) and the input fields are a bit longer to allow for easier data entry. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> Created attachment 85332 [details] [review] Bug 22170: Improve display of add/edit library group modal Tries to bring the emodal for adding/editing library root and sub groups more in line with the rest of Koha. To test: - Go to Administration > Library groups - With and without patch test following actions: - Add a new root group - Edit root group - Add sub-group entry - Edit sub-group entry - Verify that with the patch the display of the labels is more standard (bold and aligned to the right) and the input fields are a bit longer to allow for easier data entry. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.04 backported to 18.05.x for 18.05.11 |