Summary: | Holds modal no longer links to patron | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens <nick> |
Component: | Circulation | Assignee: | Nick Clemens <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, jonathan.druart, kyle.m.hall, lisettepalouse+koha, lucas, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 18789 | ||
Bug Blocks: | |||
Attachments: |
Bug 22203: Holds modal does not link to patorn account
Bug 22203: Holds modal does not link to patorn account Bug 22203: Holds modal does not link to patorn account Bug 22203: Holds modal does not link to patorn account |
Description
Nick Clemens
2019-01-24 16:48:28 UTC
Created attachment 84370 [details] [review] Bug 22203: Holds modal does not link to patorn account To test: 1 - Place a hold for a patron 2 - Check the item in at the pickup location 3 - Note the holds modal does not link to patron 4 - Apply patch 5 - Check in item again 6 - Patron name in modal is a link Created attachment 84425 [details] [review] Bug 22203: Holds modal does not link to patorn account To test: 1 - Place a hold for a patron 2 - Check the item in at the pickup location 3 - Note the holds modal does not link to patron 4 - Apply patch 5 - Check in item again 6 - Patron name in modal is a link Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Created attachment 84438 [details] [review] Bug 22203: Holds modal does not link to patorn account To test: 1 - Place a hold for a patron 2 - Check the item in at the pickup location 3 - Note the holds modal does not link to patron 4 - Apply patch 5 - Check in item again 6 - Patron name in modal is a link Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Created attachment 84447 [details] [review] Bug 22203: Holds modal does not link to patorn account To test: 1 - Place a hold for a patron 2 - Check the item in at the pickup location 3 - Note the holds modal does not link to patron 4 - Apply patch 5 - Check in item again 6 - Patron name in modal is a link Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.03 pushed to 18.05.x for 18.05.09 Nick, why did you set hide_patron_infos_if_needed=1? (In reply to Jonathan Druart from comment #9) > Nick, why did you set hide_patron_infos_if_needed=1? This was a copy/paste - reviewing how it works, this modal now respects the HidePatronName syspref - so while a change in behavior I think it should stand but am noting that effect here |