|
Description
Tomás Cohen Arazi (tcohen)
2019-01-24 19:18:58 UTC
Created attachment 84473 [details] [review] Bug 22206: OpenAPI spec Created attachment 84474 [details] [review] Bug 22206: Unit tests Created attachment 84475 [details] [review] Bug 22206: Add routes to suspend/resume holds This patch introduces: - POST /holds/{hold_id}/suspension { "expiration_date": "2019-01-30" } - DELETE /holds/{hold_id}/suspension to suspend a hold or resume a suspended hold, respectively. To test: - Apply this patches - Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => SUCCESS: Tests pass! - Sign off :-D Created attachment 85056 [details] [review] Bug 22206: OpenAPI spec Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 85057 [details] [review] Bug 22206: Unit tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 85058 [details] [review] Bug 22206: Add routes to suspend/resume holds This patch introduces: - POST /holds/{hold_id}/suspension { "expiration_date": "2019-01-30" } - DELETE /holds/{hold_id}/suspension to suspend a hold or resume a suspended hold, respectively. To test: - Apply this patches - Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Seems solid work to me.. tested and working, signing off. Created attachment 85468 [details] [review] Bug 22206: OpenAPI spec Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 85469 [details] [review] Bug 22206: Unit tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 85470 [details] [review] Bug 22206: Add routes to suspend/resume holds This patch introduces: - POST /holds/{hold_id}/suspension { "expiration_date": "2019-01-30" } - DELETE /holds/{hold_id}/suspension to suspend a hold or resume a suspended hold, respectively. To test: - Apply this patches - Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 85471 [details] [review] Bug 22206: (QA follow-up) Fix tests for hold suspension api Test plan: prove t/db_dependent/api/v1/holds.t Looks good, I think it is ready, but we should wait for voting on development meeting. So setting BLOCKED (was Passed QA) Created attachment 85862 [details] [review] Bug 22206: (follow-up) Voted RFC changes This patch changes expiration_date for end_date as voted when the RFC was approved. It also adds a test for the Location header being added correctly when suspending a hold (SWAGGER3.4.1) Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 85864 [details] [review] Bug 22206: OpenAPI spec Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 85865 [details] [review] Bug 22206: Unit tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 85866 [details] [review] Bug 22206: Add routes to suspend/resume holds This patch introduces: - POST /holds/{hold_id}/suspension { "expiration_date": "2019-01-30" } - DELETE /holds/{hold_id}/suspension to suspend a hold or resume a suspended hold, respectively. To test: - Apply this patches - Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 85867 [details] [review] Bug 22206: (QA follow-up) Fix tests for hold suspension api Test plan: prove t/db_dependent/api/v1/holds.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 85868 [details] [review] Bug 22206: (follow-up) Voted RFC changes This patch changes expiration_date for end_date as voted when the RFC was approved. It also adds a test for the Location header being added correctly when suspending a hold (SWAGGER3.4.1) Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> More testing is always fine, and I even forget to add my sign-off line last time, fixed now ;) Thanks for quick follow-up Tomas Awesome work all! Pushed to master for 19.05 As per my policy of backporting new API routes, Pushed to 18.11.x for 18.11.04 not backporting to 18.05.x *** Bug 19072 has been marked as a duplicate of this bug. *** |