Summary: | C4::Biblio->GetItemsForInventory can return wrong count / duplicated items when skipping waiting holds | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens <nick> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Josef Moravec <josef.moravec> |
Severity: | normal | ||
Priority: | P5 - low | CC: | jonathan.druart, josef.moravec, lucas, m.de.rooy, martin.renvoize, pierre-marc.thibault, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 21413 | ||
Bug Blocks: | |||
Attachments: |
Bug 22219: Add tests
Bug 22219: Remove duplicated items in inventory (when skipping waiting holds) Bug 22219: Add tests Bug 22219: Remove duplicated items in inventory (when skipping waiting holds) Bug 22219: Add tests Bug 22219: Remove duplicated items in inventory (when skipping waiting holds) |
Description
Nick Clemens
2019-01-28 19:27:13 UTC
Created attachment 86030 [details] [review] Bug 22219: Add tests Created attachment 86031 [details] [review] Bug 22219: Remove duplicated items in inventory (when skipping waiting holds) Test plan: 0/ Do not apply this patch 1/ Place several holds on a given item 2/ Use the inventory with the "skip waiting holds" option to list this item. It will be displayed several times 3/ Apply this patch and confirm that the item is now only displayed once Created attachment 86402 [details] [review] Bug 22219: Add tests Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Created attachment 86403 [details] [review] Bug 22219: Remove duplicated items in inventory (when skipping waiting holds) Test plan: 0/ Do not apply this patch 1/ Place several holds on a given item 2/ Use the inventory with the "skip waiting holds" option to list this item. It will be displayed several times 3/ Apply this patch and confirm that the item is now only displayed once Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Created attachment 86468 [details] [review] Bug 22219: Add tests Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 86469 [details] [review] Bug 22219: Remove duplicated items in inventory (when skipping waiting holds) Test plan: 0/ Do not apply this patch 1/ Place several holds on a given item 2/ Use the inventory with the "skip waiting holds" option to list this item. It will be displayed several times 3/ Apply this patch and confirm that the item is now only displayed once Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.04 missing dependency for 18.05.x not backporting |