| Summary: | JavaScript error on subscription detail page when there are no orders | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> | 
| Component: | Serials | Assignee: | Owen Leonard <oleonard> | 
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> | 
| Severity: | normal | ||
| Priority: | P5 - low | CC: | colin.campbell, dcook, fridolin.somers, lucas, martin.renvoize, nick | 
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 | 
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Bug Depends on: | 21467 | ||
| Bug Blocks: | |||
| Attachments: | 
              Bug 22239: JavaScript error on subscription detail page when there are no orders
               Bug 22239: JavaScript error on subscription detail page when there are no orders Bug 22239: JavaScript error on subscription detail page when there are no orders  | 
      ||
| 
 
        
          Description
        
        
          Owen Leonard
        
        
        
        
          2019-01-30 19:24:43 UTC
        
       
    Created attachment 84540 [details] [review] Bug 22239: JavaScript error on subscription detail page when there are no orders This page modifies the subscription detail page so that a JavaScript error isn't triggered when a subscription has no acquisition details. To test, apply the patch and go to Serials. - Locate a subscription which isn't tied to acquisitions. In the browser console there should be no errors. - Locate a subscription which is part of an order. There should be an 'Acquisitions details' tab and the order information on that tab should be displayed as a collapsible tree. *** Bug 22072 has been marked as a duplicate of this bug. *** Created attachment 85190 [details] [review] Bug 22239: JavaScript error on subscription detail page when there are no orders This page modifies the subscription detail page so that a JavaScript error isn't triggered when a subscription has no acquisition details. To test, apply the patch and go to Serials. - Locate a subscription which isn't tied to acquisitions. In the browser console there should be no errors. - Locate a subscription which is part of an order. There should be an 'Acquisitions details' tab and the order information on that tab should be displayed as a collapsible tree. Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> Created attachment 85204 [details] [review] Bug 22239: JavaScript error on subscription detail page when there are no orders This page modifies the subscription detail page so that a JavaScript error isn't triggered when a subscription has no acquisition details. To test, apply the patch and go to Serials. - Locate a subscription which isn't tied to acquisitions. In the browser console there should be no errors. - Locate a subscription which is part of an order. There should be an 'Acquisitions details' tab and the order information on that tab should be displayed as a collapsible tree. Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.04 missing dependency for 18.05.x, won't backport  |