Summary: | Pay amount - modal confirmation of amount to return to patron should be suppressed if attempting to pay (not collect) more than owed | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Fines and fees | Assignee: | Bugs List <koha-bugs> |
Status: | CLOSED WORKSFORME | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | caroline.cyr-la-rose, josef.moravec, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 11373 | ||
Bug Blocks: | |||
Attachments: | Payment fails if amount collected is higher |
Description
Nick Clemens (kidclamp)
2019-02-04 17:41:51 UTC
Created attachment 94785 [details]
Payment fails if amount collected is higher
I'm not sure if this is the same bug as the one I'm experiencing. I'm trying to understand the new "change to give" feature. If I try to pay a 19,33$ charge with a 20$ bill, I get a notification saying I owe 0,67$ to the user, I confirm, and then the payment fails because "You must pay a value less than or equal to 19.33". I attached a gif showing what I mean. To recreate: 1 - Add a fine or find a patron owing money 2 - Go to pay fines, pay amount 3 - Set amount collected higher than amount paid 4 - Note you get a confirmation modal, confirm 5 - payment fails When I attempt to recreate I get "You must pay a value less than or equal to X", so I think this is no longer a problem? (In reply to Lucas Gass from comment #3) > When I attempt to recreate I get "You must pay a value less than or equal to > X", so I think this is no longer a problem? Indeed, works for me now Caroline, can you check the db values for your patrons charges and ensure they don't owe any partial cents? If not, it may be a math error (floating point owed something like 19.32999999998) (In reply to Caroline Cyr La Rose from comment #2) > I'm not sure if this is the same bug as the one I'm experiencing. > > I'm trying to understand the new "change to give" feature. If I try to pay a > 19,33$ charge with a 20$ bill, I get a notification saying I owe 0,67$ to > the user, I confirm, and then the payment fails because "You must pay a > value less than or equal to 19.33". > > I attached a gif showing what I mean. > > To recreate: > 1 - Add a fine or find a patron owing money > 2 - Go to pay fines, pay amount > 3 - Set amount collected higher than amount paid > 4 - Note you get a confirmation modal, confirm > 5 - payment fails Maybe this one: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26076 Indeed, it works now. :) Caroline |