Summary: | Keydown event properties (keyCode and which) are both deprecated | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Browser compatibility | Assignee: | Owen Leonard <oleonard> |
Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | emily.lamancusa, oleonard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36580 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: |
Description
Marcel de Rooy
2019-02-06 13:37:01 UTC
Most mentions of keypress now are in JS libraries, but we have some in our own files: koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt koha-tmpl/intranet-tmpl/prog/js/staff-global.js koha-tmpl/intranet-tmpl/prog/js/subscription-add.js koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/sci/sci-main.tt koha-tmpl/opac-tmpl/bootstrap/js/global.js *** This bug has been marked as a duplicate of bug 36580 *** I don't think this is a duplicate of 36580, exactly, though they're closely related. This bug was about replacing the deprecated keypress event with a keydown event(?) instead. The instance that prompted me to file 36580 already uses keydown rather than keypress (I think), but uses deprecated methods of identifying which key. I assumed that if we were going to address deprecated key events we would do so in one place. |