|
Description
Christophe Croullebois
2019-02-06 14:57:57 UTC
Created attachment 84829 [details] [review] Fix-PDF-issue-in-layout3pagesfr.pm To test : Without the patch : 1° select in Acquisitions preferences/OrderPdfFormat French 3-page 2° restart plack if needed 3° In acqui/basketgroup.pl select closed tab 4° Click on "Export as PDF" button 5° You should see a blank page saying "Internal Server Error" With the patch : Do the same Thx for tests Package is usually the first line of file. You should keep it and remove second line. Created attachment 84854 [details] [review] Bug 22282 - Fix PDF issue when exporting PDF in French format. Fixing up QA comments, keeping 1st instance and removing the 2nd. Original test plan by Christophe Croullebois. To test : Without the patch : 1° select in Acquisitions preferences/OrderPdfFormat French 3-page 2° restart plack if needed 3° In acqui/basketgroup.pl select closed tab 4° Click on "Export as PDF" button 5° You should see a blank page saying "Internal Server Error" With the patch : Do the same Created attachment 84891 [details] [review] Bug 22282 - Fix PDF issue when exporting PDF in French format. Fixing up QA comments, keeping 1st instance and removing the 2nd. Original test plan by Christophe Croullebois. To test : Without the patch : 1° select in Acquisitions preferences/OrderPdfFormat French 3-page 2° restart plack if needed 3° In acqui/basketgroup.pl select closed tab 4° Click on "Export as PDF" button 5° You should see a blank page saying "Internal Server Error" With the patch : Do the same Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Created attachment 84910 [details] [review] Bug 22282 - Fix PDF issue when exporting PDF in French format. Fixing up QA comments, keeping 1st instance and removing the 2nd. Original test plan by Christophe Croullebois. To test : Without the patch : 1° select in Acquisitions preferences/OrderPdfFormat French 3-page 2° restart plack if needed 3° In acqui/basketgroup.pl select closed tab 4° Click on "Export as PDF" button 5° You should see a blank page saying "Internal Server Error" With the patch : Do the same Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.03 backported to 18.05.x for 18.05.09 Pushed to 17.11.x for 17.11.15 |