Bug 22293

Summary: Sticky toolbar making vendor form uneditable
Product: Koha Reporter: Aleisha Amohia <aleisha>
Component: AcquisitionsAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: katrin.fischer, martin.renvoize, nick, oleonard
Version: master   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 21751    
Bug Blocks:    
Attachments: Bug 22293: Sticky toolbar making vendor form uneditable
Bug 22293: Sticky toolbar making vendor form uneditable
Bug 22293: Sticky toolbar making vendor form uneditable
Bug 22293: Sticky toolbar making vendor form uneditable

Description Aleisha Amohia 2019-02-08 04:35:33 UTC
The HC-sticky toolbar from Bug 21751 does not work on /cgi-bin/koha/acqui/supplier.pl

When I go to add a new vendor or edit an existing one, I can't click anywhere on the form.
Comment 1 Katrin Fischer 2019-02-08 07:03:47 UTC
Confirmed :(
Comment 2 Owen Leonard 2019-02-08 13:04:33 UTC
Created attachment 84864 [details] [review]
Bug 22293: Sticky toolbar making vendor form uneditable

The new floating toolbar plugin doesn't like a particular combination of
markup: A toolbar inside a form which is styled "display:inline." The
staff client CSS styles forms that way globally, so it must be
explicitly overridden in these situations.

Changing the default will have broad consequences, so I propose an
inline style to fix this.

To test, apply the patch and go to Acquisitions. Add or edit a vendor
and confirm that after scrolling down the page the form is still
editable.
Comment 3 Andrew Isherwood 2019-02-08 14:01:47 UTC
Created attachment 84865 [details] [review]
Bug 22293: Sticky toolbar making vendor form uneditable

The new floating toolbar plugin doesn't like a particular combination of
markup: A toolbar inside a form which is styled "display:inline." The
staff client CSS styles forms that way globally, so it must be
explicitly overridden in these situations.

Changing the default will have broad consequences, so I propose an
inline style to fix this.

To test, apply the patch and go to Acquisitions. Add or edit a vendor
and confirm that after scrolling down the page the form is still
editable.

Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
Comment 4 Mikaël Olangcay Brisebois 2019-02-08 21:08:01 UTC
Created attachment 84904 [details] [review]
Bug 22293: Sticky toolbar making vendor form uneditable

The new floating toolbar plugin doesn't like a particular combination of
markup: A toolbar inside a form which is styled "display:inline." The
staff client CSS styles forms that way globally, so it must be
explicitly overridden in these situations.

Changing the default will have broad consequences, so I propose an
inline style to fix this.

To test, apply the patch and go to Acquisitions. Add or edit a vendor
and confirm that after scrolling down the page the form is still
editable.

Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
Signed-off-by: Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com>
Comment 5 Katrin Fischer 2019-02-09 19:31:03 UTC
Created attachment 84908 [details] [review]
Bug 22293: Sticky toolbar making vendor form uneditable

The new floating toolbar plugin doesn't like a particular combination of
markup: A toolbar inside a form which is styled "display:inline." The
staff client CSS styles forms that way globally, so it must be
explicitly overridden in these situations.

Changing the default will have broad consequences, so I propose an
inline style to fix this.

To test, apply the patch and go to Acquisitions. Add or edit a vendor
and confirm that after scrolling down the page the form is still
editable.

Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
Signed-off-by: Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Katrin Fischer 2019-02-09 19:31:32 UTC
Thx for the quick fix and 2 sign-offs!
Comment 7 Nick Clemens 2019-02-11 18:45:38 UTC
Awesome work all!

Pushed to master for 19.05
Comment 8 Martin Renvoize 2019-02-12 13:00:55 UTC
Bug in enhancement not in 18.11.x series.