| Summary: | Sticky toolbar making vendor form uneditable | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
| Component: | Acquisitions | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | martin.renvoize, nick, oleonard |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 21751 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 22293: Sticky toolbar making vendor form uneditable
Bug 22293: Sticky toolbar making vendor form uneditable Bug 22293: Sticky toolbar making vendor form uneditable Bug 22293: Sticky toolbar making vendor form uneditable |
||
|
Description
Aleisha Amohia
2019-02-08 04:35:33 UTC
Confirmed :( Created attachment 84864 [details] [review] Bug 22293: Sticky toolbar making vendor form uneditable The new floating toolbar plugin doesn't like a particular combination of markup: A toolbar inside a form which is styled "display:inline." The staff client CSS styles forms that way globally, so it must be explicitly overridden in these situations. Changing the default will have broad consequences, so I propose an inline style to fix this. To test, apply the patch and go to Acquisitions. Add or edit a vendor and confirm that after scrolling down the page the form is still editable. Created attachment 84865 [details] [review] Bug 22293: Sticky toolbar making vendor form uneditable The new floating toolbar plugin doesn't like a particular combination of markup: A toolbar inside a form which is styled "display:inline." The staff client CSS styles forms that way globally, so it must be explicitly overridden in these situations. Changing the default will have broad consequences, so I propose an inline style to fix this. To test, apply the patch and go to Acquisitions. Add or edit a vendor and confirm that after scrolling down the page the form is still editable. Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Created attachment 84904 [details] [review] Bug 22293: Sticky toolbar making vendor form uneditable The new floating toolbar plugin doesn't like a particular combination of markup: A toolbar inside a form which is styled "display:inline." The staff client CSS styles forms that way globally, so it must be explicitly overridden in these situations. Changing the default will have broad consequences, so I propose an inline style to fix this. To test, apply the patch and go to Acquisitions. Add or edit a vendor and confirm that after scrolling down the page the form is still editable. Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Signed-off-by: Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> Created attachment 84908 [details] [review] Bug 22293: Sticky toolbar making vendor form uneditable The new floating toolbar plugin doesn't like a particular combination of markup: A toolbar inside a form which is styled "display:inline." The staff client CSS styles forms that way globally, so it must be explicitly overridden in these situations. Changing the default will have broad consequences, so I propose an inline style to fix this. To test, apply the patch and go to Acquisitions. Add or edit a vendor and confirm that after scrolling down the page the form is still editable. Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Signed-off-by: Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Thx for the quick fix and 2 sign-offs! Awesome work all! Pushed to master for 19.05 Bug in enhancement not in 18.11.x series. |