| Summary: | ITEMTYPECAT description doesn't fall back to description if OPAC description is empty | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | OPAC | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | 1joynelson, andrew, hayleypelham, jonathan.druart, kelly, lucas |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.03, 19.05.08, 18.11.14
|
|
| Circulation function: | |||
| Attachments: |
Bug 22302: Unit tests
Bug 22302: Make ITEMTYPECAT descriptions fallback to lib description if no opac description Bug 22302: Unit tests Bug 22302: Make ITEMTYPECAT descriptions fallback to lib description if no opac description Bug 22302: Unit tests Bug 22302: Make ITEMTYPECAT descriptions fallback to lib description if no opac description |
||
|
Description
Katrin Fischer
2019-02-10 13:03:21 UTC
Agreed this is a pesky inconsistency. Easy enough to work around, but an annoying little trap for new users. Created attachment 98395 [details] [review] Bug 22302: Unit tests Created attachment 98396 [details] [review] Bug 22302: Make ITEMTYPECAT descriptions fallback to lib description if no opac description Test plan: - create an authorized value in the ITEMTYPECAT category, give it a description but not a description (OPAC) - connect an item type to your category - go to the advanced search page on the OPAC - see a radio button with no label - apply patch - reload OPAC adv search page - radio button has a label Created attachment 98410 [details] [review] Bug 22302: Unit tests Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Created attachment 98411 [details] [review] Bug 22302: Make ITEMTYPECAT descriptions fallback to lib description if no opac description Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Amended test plan: 1 create an authorized value in the ITEMTYPECAT category, give it a description but not a description (OPAC) 2 connect an item type to your category 3 go to the advanced search page on the OPAC 4 see a radio button with no label 5 apply patch 6 reload OPAC adv search page 7 radio button has a label 8 go back to authorized values and add a Description (OPAC) that does not match Description 9 Reload OPAC and see that your radio button shows Description (OPAC) Signing off. Created attachment 98443 [details] [review] Bug 22302: Unit tests Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Created attachment 98444 [details] [review] Bug 22302: Make ITEMTYPECAT descriptions fallback to lib description if no opac description Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Nice work everyone! Pushed to master for 20.05 Pushed to 19.11.x branch for 19.11.03 backported to 19.05.x for 19.05.08 Backported to 18.11.x for 18.11.14 |