Bug 22312

Summary: BlockReturnOfLostItems does not prevent lost items filling holds
Product: Koha Reporter: Phil Ringnalda <phil>
Component: CirculationAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: gmcharlt, kyle.m.hall
Version: unspecified   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35587
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:

Description Phil Ringnalda 2019-02-11 22:31:34 UTC
When the preference BlockReturnOfLostItems is set, it prevents checkin from checking the item in, but it does not prevent prompting to fill a hold with that item.

Steps to reproduce:

1. Set BlockReturnOfLostItems to Block
2. Place a hold that can be filled by a particular item
3. Mark that item as Lost (or Missing, or any other flavor of lost)
3. Attempt to check in that item

Expected results:

Message stating that "Item is lost, cannot be checked in./Cannot check in/NOT CHECKED IN", no message about the hold.

Actual results:

The "Item is lost, cannot be checked in./Cannot check in/NOT CHECKED IN" message displays in the page, but is quickly covered by the popup saying that it can fill a hold. If any of the Confirm buttons (Confirm, Confirm and print slip, Confirm and transfer) is clicked in the hold popup, when the popup closes the message in the page below is removed, leaving no sign that the hold was just filled by an item which is now both being held and also lost.
Comment 1 Phil Ringnalda 2019-03-29 18:38:40 UTC
Ah, http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Circulation.pm;hb=6666918dd661b0207366becefd1480257197a353#l2050 checks for $item->withdrawn, but not for $item->itemlost, before filling holds.