Summary: | Overzealous deletion of data in t/db_dependant/Koha/Acquisitions/Booksellers.t | ||
---|---|---|---|
Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
Component: | Test Suite | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
Status: | CLOSED FIXED | QA Contact: | Josef Moravec <josef.moravec> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | jonathan.druart, josef.moravec, nick, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 22349: Remove overzealous database deletions from test
Bug 22349: Remove overzealous database deletions from test Bug 22349: Remove overzealous database deletions from test |
Description
Martin Renvoize (ashimema)
2019-02-15 14:31:25 UTC
Created attachment 85177 [details] [review] Bug 22349: Remove overzealous database deletions from test For no apparent reason a whole lot of data was being deleted inside a transaction for each of the subtests in Koha/Acquisitions/Booksellers.t This patch simply remove the deletions. To test, run the test before and after applying the patch and they should all continue to pass.. If you have a large number of booksellers, baskets, orders or subscriptions in your database you may also see an decrease in the time it takes to run the test. Created attachment 85223 [details] [review] Bug 22349: Remove overzealous database deletions from test For no apparent reason a whole lot of data was being deleted inside a transaction for each of the subtests in Koha/Acquisitions/Booksellers.t This patch simply remove the deletions. To test, run the test before and after applying the patch and they should all continue to pass.. If you have a large number of booksellers, baskets, orders or subscriptions in your database you may also see an decrease in the time it takes to run the test. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 85233 [details] [review] Bug 22349: Remove overzealous database deletions from test For no apparent reason a whole lot of data was being deleted inside a transaction for each of the subtests in Koha/Acquisitions/Booksellers.t This patch simply remove the deletions. To test, run the test before and after applying the patch and they should all continue to pass.. If you have a large number of booksellers, baskets, orders or subscriptions in your database you may also see an decrease in the time it takes to run the test. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Good catch Awesome work all! Pushed to master for 19.05 |