| Summary: | Add shelving location to Holds awaiting pickup report | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Matthias Meusburger <matthias.meusburger> |
| Component: | Hold requests | Assignee: | Matthias Meusburger <matthias.meusburger> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | gmcharlt, jose-mario.monteiro-santos, martin.renvoize, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
19.05.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 22372 - Add available location to Holds awaiting pickup
Bug 22171: Fix shipping cost display on invoice Bug 22372 - Add available location to Holds awaiting pickup Bug 22372: Add available location to Holds awaiting pickup Bug 22372: (QA follow-up) Change 'Available location' to 'Shelving location' |
||
|
Description
Matthias Meusburger
2019-02-19 15:48:52 UTC
Created attachment 85285 [details] [review] Bug 22372 - Add available location to Holds awaiting pickup Test plan: - Go to Circulation, Holds awaiting pickup (circ/waitingreserves.pl) - Note the additional column for available location. Created attachment 85575 [details] [review] Bug 22171: Fix shipping cost display on invoice When not 0 the shipping cost on the invoice would display with a lot of numbers after the comma. This fixed it to display with only 2. To test: - Make sure you have an invoice with shipping cost set (example: 5.00) - Open the invoice for editing (invoice.pl) - Verify the shipping cost displays with too many decimals (5.000000) - Apply patch - Verify now the shipping cost displays correctly (5.00) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: bin.wen <bin.wen@inlibro.com> Hi Bin, I tihnk you might have typoed on the bug number - resetting this bug here. Do you want ot attach your sign-off to bug 22171? Or the right patch here? Created attachment 86931 [details] [review] Bug 22372 - Add available location to Holds awaiting pickup Test plan: - Go to Circulation, Holds awaiting pickup (circ/waitingreserves.pl) - Note the additional column for available location. Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com> As we know for sure which item will fill the hold here, I think we can just make it: Location, instead of "Available location". I'll add a tiny follow-up. Created attachment 87565 [details] [review] Bug 22372: Add available location to Holds awaiting pickup Test plan: - Go to Circulation, Holds awaiting pickup (circ/waitingreserves.pl) - Note the additional column for available location. Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 87566 [details] [review] Bug 22372: (QA follow-up) Change 'Available location' to 'Shelving location' Make terminology more consistent with other places in Koha. Awesome work all! Pushed to master for 19.05 Enhancement will not be backported to 18.11.x series. |