Bug 22378

Summary: Fix sound alerts on SCO
Product: Koha Reporter: Nick Clemens <nick>
Component: Self checkoutAssignee: Nick Clemens <nick>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: jesse, jonathan.druart+koha, martin.renvoize
Version: master   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 22441, 18251    
Attachments: Bug 22378: Fix audio alerts on SCO
Bug 22378: Fix audio alerts on SCO

Description Nick Clemens 2019-02-20 19:59:40 UTC

    
Comment 1 Nick Clemens 2019-02-20 20:01:57 UTC
Created attachment 85410 [details] [review]
Bug 22378: Fix audio alerts on SCO

Note: The SCO only supports sounds with a full URL, not KOha built in sounds

To test:
1 - Enable audio alerts
2 -  Enable SCO
3 - Note JS error on loading the alerts
4 - Apply patch
5 - No more error
6 - Test with bug 18251
Comment 2 Josef Moravec 2019-02-25 13:29:36 UTC
Created attachment 85615 [details] [review]
Bug 22378: Fix audio alerts on SCO

Note: The SCO only supports sounds with a full URL, not KOha built in sounds

To test:
1 - Enable audio alerts
2 -  Enable SCO
3 - Note JS error on loading the alerts
4 - Apply patch
5 - No more error
6 - Test with bug 18251

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 3 Nick Clemens 2019-02-26 13:18:05 UTC
Trivial, skipping QA
Comment 4 Nick Clemens 2019-02-26 14:41:07 UTC
Awesome work all!

Pushed to master for 19.05
Comment 5 Martin Renvoize 2019-03-01 11:08:09 UTC
Pushed to 18.11.x for 18.11.04.

I'm sure we've broken this sort of thing a few times.. would have liked to have seen a selenium test for it...
Comment 6 Jesse Maseto 2019-03-08 18:59:05 UTC
Patch doesn't apply cleanly. Please rebase if needed for 18.05.x.