| Summary: | Fix sound alerts on SCO | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Self checkout | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | jesse, jonathan.druart, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 18251, 22441 | ||
| Attachments: |
Bug 22378: Fix audio alerts on SCO
Bug 22378: Fix audio alerts on SCO |
||
|
Description
Nick Clemens (kidclamp)
2019-02-20 19:59:40 UTC
Created attachment 85410 [details] [review] Bug 22378: Fix audio alerts on SCO Note: The SCO only supports sounds with a full URL, not KOha built in sounds To test: 1 - Enable audio alerts 2 - Enable SCO 3 - Note JS error on loading the alerts 4 - Apply patch 5 - No more error 6 - Test with bug 18251 Created attachment 85615 [details] [review] Bug 22378: Fix audio alerts on SCO Note: The SCO only supports sounds with a full URL, not KOha built in sounds To test: 1 - Enable audio alerts 2 - Enable SCO 3 - Note JS error on loading the alerts 4 - Apply patch 5 - No more error 6 - Test with bug 18251 Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Trivial, skipping QA Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.04. I'm sure we've broken this sort of thing a few times.. would have liked to have seen a selenium test for it... Patch doesn't apply cleanly. Please rebase if needed for 18.05.x. |