| Summary: | Remove C4::Accounts::manualinvoice | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
| Component: | Architecture, internals, and plumbing | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | david, josef.moravec, kyle, lucas, nick, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 22393 | ||
| Bug Blocks: | 22510 | ||
| Attachments: |
Bug 22394: Remove C4::Accounts::manualinvoice
Bug 22394: Remove C4::Accounts::manualinvoice Bug 22394: Remove C4::Accounts::manualinvoice Bug 22394: Remove C4::Accounts::manualinvoice |
||
|
Description
Martin Renvoize (ashimema)
2019-02-22 11:17:14 UTC
We have been warning via a deprecation warning since the release of 19.05.00.. with the release of 20.11 it will make 18 months of the warning having been fired so I think we're safe to remove it now This was a nice example of the use of the deprecated method from Mojo::Utils to give warning of a method being removed prior to it's actual removal.. I wonder.. did people find this helpful and should we adopt the practice more widely? Created attachment 108588 [details] [review] Bug 22394: Remove C4::Accounts::manualinvoice This patch removes C4::Accounts::manualinvoice and it's corresponding test. We have been warning deprecation of this method for 18 months (by the time of 20.11 release). Test plan 1/ Apply patch 2/ Ensure no mention of manualinvoice accross the codebase Patch no longer applies 8-( Notes for testing: - Find usage of manualinvoice: git grep manualinvoice - Search before applying patch - After apply patch should be no occurrences Created attachment 111991 [details] [review] Bug 22394: Remove C4::Accounts::manualinvoice This patch removes C4::Accounts::manualinvoice and it's corresponding test. We have been warning deprecation of this method for 18 months (by the time of 20.11 release). Test plan 1/ Apply patch 2/ Ensure no mention of manualinvoice accross the codebase 3/ Run t/db_dependant/Accounts.t and ensure it still passes Created attachment 112259 [details] [review] Bug 22394: Remove C4::Accounts::manualinvoice This patch removes C4::Accounts::manualinvoice and it's corresponding test. We have been warning deprecation of this method for 18 months (by the time of 20.11 release). Test plan 1/ Apply patch 2/ Ensure no mention of manualinvoice accross the codebase 3/ Run t/db_dependant/Accounts.t and ensure it still passes Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Created attachment 112361 [details] [review] Bug 22394: Remove C4::Accounts::manualinvoice This patch removes C4::Accounts::manualinvoice and it's corresponding test. We have been warning deprecation of this method for 18 months (by the time of 20.11 release). Test plan 1/ Apply patch 2/ Ensure no mention of manualinvoice accross the codebase 3/ Run t/db_dependant/Accounts.t and ensure it still passes Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 20.11, thanks to everybody involved! enhancement will not be backported to 20.05.x |