Summary: | koha-sip script does not start the server correctly | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Command-line Utilities | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | major | ||
Priority: | P5 - low | CC: | fridolin.somers, lucas, martin.renvoize, nick, robin |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 18562 | ||
Bug Blocks: | |||
Attachments: |
Bug 22396: Make koha-sip set KOHA_HOME and KOHA_CONF correctly
Bug 22396: Make koha-sip set KOHA_HOME and KOHA_CONF correctly |
Description
Jonathan Druart
2019-02-22 14:13:50 UTC
kohadev+ 28268 0.0 0.0 18612 192 ? S 11:10 0:00 daemon --name=kohadev-koha-sip --errlog=/var/log/koha/kohadev/sip-error.log --stdout=/var/log/koha/kohadev/sip.log --output=/var/log/koha/kohadev/sip-output.log --verbose=1 --respawn --delay=30 --pidfiles=/var/run/koha/kohadev --user=kohadev-koha.kohadev-koha -- perl /home/vagrant/kohaclone/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml This is because of a typo and the fact that KOHA_CONF is not set in ENV. Created attachment 85562 [details] [review] Bug 22396: Make koha-sip set KOHA_HOME and KOHA_CONF correctly This patch corrects a typo, and exports KOHA_CONF as other scripts do. To test: - Apply this patch - Run: $ # in kohadevbox $ perl misc4dev/cp_debian_files.pl - Try the new script $ sudo koha-sip --start kohadev => SUCCESS: tail -f /var/log/koha/kohadev/sip* doesn't show fatal errors anymore - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 85563 [details] [review] Bug 22396: Make koha-sip set KOHA_HOME and KOHA_CONF correctly This patch corrects a typo, and exports KOHA_CONF as other scripts do. To test: - Apply this patch - Run: $ # in kohadevbox $ perl misc4dev/cp_debian_files.pl - Try the new script $ sudo koha-sip --start kohadev => SUCCESS: tail -f /var/log/koha/kohadev/sip* doesn't show fatal errors anymore - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Trivial, skipping QA. Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.04 missing 18562 dependency for 18.05.x, wont backport |