Summary: | Holds to pull report is broken in sql strict mode | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Circulation | Assignee: | Bugs List <koha-bugs> |
Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, jonathan.druart, kyle.m.hall, martin.renvoize, oleonard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23484 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23485 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23360 |
||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 13640 | ||
Bug Blocks: | 17258 |
Description
Nick Clemens (kidclamp)
2019-02-28 11:35:19 UTC
Hi Nick, can you add how the bug manifests? What is the wrong behaivour? Enable strict mode Have some holds to pull Browse to Circulation -> Holds to pull Internal Server Error The report cannot run in strict mode due to using columns not included in GROUP BY I have a "PFFF rewriting pendingreserves.pl" commit on a local branch, if anyone is willing to work on/continue it. *** Bug 23175 has been marked as a duplicate of this bug. *** (In reply to Jonathan Druart from comment #3) > I have a "PFFF rewriting pendingreserves.pl" commit on a local branch, if > anyone is willing to work on/continue it. I'm game for looking at this. (In reply to Martin Renvoize from comment #5) > (In reply to Jonathan Druart from comment #3) > > I have a "PFFF rewriting pendingreserves.pl" commit on a local branch, if > > anyone is willing to work on/continue it. > > I'm game for looking at this. https://gitlab.com/joubu/Koha/commits/bug_22431 That's super dirty and I am not really sure what I was trying to achieve. IIRC the problem was the GROUP_CONCAT clause. So creating relevant data, executing the query, then comparing with what would replace the query (using Koha::Holds). That's really a work in progress but... not finished :) Good luck! *** Bug 26020 has been marked as a duplicate of this bug. *** *** Bug 26489 has been marked as a duplicate of this bug. *** If duplicate reports have been made on this bug THREE TIMES I think it's time to change the title!! (In reply to Owen Leonard from comment #9) > If duplicate reports have been made on this bug THREE TIMES I think it's > time to change the title!! You make an excellent point there. Yikes, I offered to take a look then promptly completely forgot about it... Catching up now. Effort must be done on bug 24488. *** This bug has been marked as a duplicate of bug 24488 *** |