Bug 22448

Summary: advance_notices.pl generates DUE(DGST) too early
Product: Koha Reporter: Magnus Enger <magnus>
Component: Command-line UtilitiesAssignee: Bugs List <koha-bugs>
Status: CLOSED WONTFIX QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: robin
Version: Main   
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Crowdfunding committed: 0
Crowdfunding contact: Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Description Magnus Enger 2019-03-04 10:13:35 UTC
Looking in message_queue, I see DUE messages with

    message_queue.time_queued = 2019-03-04 00:10:07

where the content says 

    The following item is now due:

and gives a due date/time of:

    2019-03-04 23:59 ...

So the loan is actually not due for another 23 hours and 49 minutes. This is especially bothersome for one-day-loans, where the DUE(DGST) messages are never triggered, because the trigger is set off before the patron has a chance to borrow the item. 

Wouldn't it be better to fire off the DUE(DGST) messages 24 hours later, so at 2019-03-05 00:10:07 it would say "The following item is now due: 2019-03-04 23:59 ..."? Or am I missing something?
Comment 1 Katrin Fischer 2019-03-05 06:34:54 UTC
Due messages are sent the day the item is due = can be returned without without being late. I think this is the correct behavior, it warns you before things get overdue. (2019-03-04 sent on -05 would be overdue)
Comment 2 Magnus Enger 2019-03-05 10:41:00 UTC
You are right, of course. And changing the wording of the message a bit would make it make more sense. Closing.