|
Description
Jonathan Druart
2019-03-04 18:51:29 UTC
Created attachment 86034 [details] [review] Bug 22451: Make Asset plugin use Koha::version instead of version from db Test plan: Apply the patch a try to use Koha, css and js files should be used normally Created attachment 86035 [details] [review] Bug 22451: Update test Test plan: prove t/db_dependent/Koha/Template/Plugin/Asset.t Created attachment 86036 [details] [review] Bug 22451: Use Asset everywhere Test plan: Use installer and onboaarding tool, make sure the js and css files are loaded error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/includes/installer-doc-head-close.inc). 1. I'd say there is a dot missing: $1$2$3 should be $1.$2$3 to match the value in the DB 2. I do not understand the changes in the tests. Created attachment 86115 [details] [review] Bug 22451: Make Asset plugin use Koha::version instead of version from db Test plan: Apply the patch a try to use Koha, css and js files should be used normally Created attachment 86116 [details] [review] Bug 22451: Update test Test plan: prove t/db_dependent/Koha/Template/Plugin/Asset.t Created attachment 86117 [details] [review] Bug 22451: Use Asset everywhere Test plan: Use installer and onboaarding tool, make sure the js and css files are loaded (In reply to Jonathan Druart from comment #5) > 1. I'd say there is a dot missing: > $1$2$3 should be $1.$2$3 to match the value in the DB $1 is for first two version parts with dot... so dot is here, but I agree it is not obvious... maybe better to format regex with 4 parts to make it better readable - i updated the first patch > > 2. I do not understand the changes in the tests. When database is not fully updated, then the test could fail if using version preference... maybe a bit Created attachment 87821 [details] [review] Bug 22451: Make Asset plugin use Koha::version instead of version from db Test plan: Apply the patch a try to use Koha, css and js files should be used normally Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Created attachment 87822 [details] [review] Bug 22451: Update test Test plan: prove t/db_dependent/Koha/Template/Plugin/Asset.t Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Created attachment 87823 [details] [review] Bug 22451: Use Asset everywhere Test plan: Use installer and onboaarding tool, make sure the js and css files are loaded Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Created attachment 87897 [details] [review] Bug 22451: Make Asset plugin use Koha::version instead of version from db Test plan: Apply the patch a try to use Koha, css and js files should be used normally Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 87899 [details] [review] Bug 22451: Update test Test plan: prove t/db_dependent/Koha/Template/Plugin/Asset.t Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 87900 [details] [review] Bug 22451: Use Asset everywhere Test plan: Use installer and onboaarding tool, make sure the js and css files are loaded Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.05 missing dependency for 18.05.x, not backporting |