Bug 22471

Summary: Default Finnish values for web installer
Product: Koha Reporter: Lari Taskula <lari.taskula>
Component: Installation and upgrade (web-based installer)Assignee: Lari Taskula <lari.taskula>
Status: Failed QA --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: gmcharlt, katrin.fischer, wizzyrea
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: Sponsored Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 22471: Add installer/data/mysql/fi-FI (1/2)
Bug 22471: Add installer/data/mysql/fi-FI (2/2)
Bug 22471: Mandatory Finnish installer values
Bug 22471: Optional Finnish installer values
Bug 22471: Add system preferences for Finnish installer
Bug 22471: Add installer/data/mysql/fi-FI
Bug 22471: Mandatory Finnish installer values
Bug 22471: Optional Finnish installer values
Bug 22471: Add system preferences for Finnish installer
Bug 22471: Add installer/data/mysql/fi-FI
Bug 22471: Mandatory Finnish installer values
Bug 22471: Optional Finnish installer values
Bug 22471: Add system preferences for Finnish installer

Description Lari Taskula 2019-03-07 12:11:10 UTC
Add default Finnish values for web installer.
Comment 1 Lari Taskula 2019-03-20 00:43:55 UTC
Created attachment 86761 [details] [review]
Bug 22471: Add installer/data/mysql/fi-FI (1/2)
Comment 2 Lari Taskula 2019-03-20 00:44:07 UTC
Created attachment 86762 [details] [review]
Bug 22471: Add installer/data/mysql/fi-FI (2/2)
Comment 3 Lari Taskula 2019-03-20 00:44:20 UTC
Created attachment 86763 [details] [review]
Bug 22471: Mandatory Finnish installer values

Sponsored-by: Hypernova Oy
Comment 4 Lari Taskula 2019-03-20 00:44:31 UTC
Created attachment 86764 [details] [review]
Bug 22471: Optional Finnish installer values

Sponsored-by: Hypernova Oy
Comment 5 Lari Taskula 2019-03-20 00:45:24 UTC
Created attachment 86765 [details] [review]
Bug 22471: Add system preferences for Finnish installer

To test:
1. Apply all patches in this Bug
2. Create an empty database. Make sure database user has permissions to it and
   $KOHA_CONF is pointing to the correct database.
3. Add Finnish translation, for help, see:
   https://wiki.koha-community.org/wiki/Installation_of_additional_languages_for_OPAC_and_INTRANET_staff_client
4. Run web installer and select fi-FI as installer language
5. Select all mandatory and optional default values
6. Finish installation and make sure you get no SQL errors

Sponsored-by: Hypernova Oy
Comment 6 Lari Taskula 2019-03-20 00:46:53 UTC
Created attachment 86766 [details] [review]
Bug 22471: Add installer/data/mysql/fi-FI

This patch adds a direct copy of installer/data/mysql/en.

No translations provided in this patch!

Sponsored-by: Hypernova Oy
Comment 7 Lari Taskula 2019-03-20 00:47:08 UTC
Created attachment 86767 [details] [review]
Bug 22471: Mandatory Finnish installer values

Sponsored-by: Hypernova Oy
Comment 8 Lari Taskula 2019-03-20 00:47:41 UTC
Created attachment 86768 [details] [review]
Bug 22471: Optional Finnish installer values

Sponsored-by: Hypernova Oy
Comment 9 Lari Taskula 2019-03-20 00:47:54 UTC
Created attachment 86769 [details] [review]
Bug 22471: Add system preferences for Finnish installer

To test:
1. Apply all patches in this Bug
2. Create an empty database. Make sure database user has permissions to it and
   $KOHA_CONF is pointing to the correct database.
3. Add Finnish translation, for help, see:
   https://wiki.koha-community.org/wiki/Installation_of_additional_languages_for_OPAC_and_INTRANET_staff_client
4. Run web installer and select fi-FI as installer language
5. Select all mandatory and optional default values
6. Finish installation and make sure you get no SQL errors

Sponsored-by: Hypernova Oy
Comment 10 Liz Rea 2019-05-24 16:26:59 UTC
Created attachment 90068 [details] [review]
Bug 22471: Add installer/data/mysql/fi-FI

This patch adds a direct copy of installer/data/mysql/en.

No translations provided in this patch!

Sponsored-by: Hypernova Oy

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Comment 11 Liz Rea 2019-05-24 16:27:11 UTC
Created attachment 90069 [details] [review]
Bug 22471: Mandatory Finnish installer values

Sponsored-by: Hypernova Oy

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Comment 12 Liz Rea 2019-05-24 16:27:14 UTC
Created attachment 90070 [details] [review]
Bug 22471: Optional Finnish installer values

Sponsored-by: Hypernova Oy

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Comment 13 Liz Rea 2019-05-24 16:27:17 UTC
Created attachment 90071 [details] [review]
Bug 22471: Add system preferences for Finnish installer

To test:
1. Apply all patches in this Bug
2. Create an empty database. Make sure database user has permissions to it and
   $KOHA_CONF is pointing to the correct database.
3. Add Finnish translation, for help, see:
   https://wiki.koha-community.org/wiki/Installation_of_additional_languages_for_OPAC_and_INTRANET_staff_client
4. Run web installer and select fi-FI as installer language
5. Select all mandatory and optional default values
6. Finish installation and make sure you get no SQL errors

Sponsored-by: Hypernova Oy

Signed-off-by: Liz Rea <wizzyrea@gmail.com>

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Comment 14 Liz Rea 2019-05-24 16:28:24 UTC
Please note that I do not verify the correctness of any translation, but I do confirm that we can get through the installer and the onboarding with the sample data.
Comment 15 Katrin Fischer 2019-05-28 05:21:12 UTC
I got some SQL errors testing this:

Pakollinen tieto lisätty

    subtag_registry.sql
    auth_val_cat.sql
    message_transport_types.sql
    sample_notices_message_attributes.sql
    sample_notices_message_transports.sql
    auth_values.sql
    authorities_normal_marc21.sql
    class_sources.sql
    marc21_framework_DEFAULT.sql
    message_transport_types.sql

    DBD::mysql::st execute failed: Duplicate entry 'email' for key 'PRIMARY' at /usr/share/perl5/DBIx/RunSQL.pm line 273.
    sample_frequencies.sql
    sample_notices.sql
    sample_notices_message_attributes.sql

    DBD::mysql::st execute failed: Duplicate entry '1' for key 'PRIMARY' at /usr/share/perl5/DBIx/RunSQL.pm line 273.
    sample_notices_message_transports.sql

    DBD::mysql::st execute failed: Duplicate entry '1-email-0' for key 'PRIMARY' at /usr/share/perl5/DBIx/RunSQL.pm line 273.
    sample_numberpatterns.sql
    system_preferences.sql

I think this might be a conflict with bug 21651. I am sorry!
Comment 16 Katrin Fischer 2023-09-23 22:51:09 UTC
We have since standardized the installer and moved translations to the translation tools. Maybe the last patch could still be interesting for a custom.sql?