Summary: | Use koha-conf.xml modification time as cache key | ||
---|---|---|---|
Product: | Koha | Reporter: | Robin Sheat <robin> |
Component: | Architecture, internals, and plumbing | Assignee: | Bugs List <koha-bugs> |
Status: | In Discussion --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | jonathan.druart, magnus, martin.renvoize, tomascohen |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 22473: flush in psgi - V1
Bug 22473: Two other places that do not work - V2 Bug 22473: Handle config expiration in C4::Context->new - V3 Bug 22473: Example of watcher to invalidate config cache - V4 |
Description
Robin Sheat
2019-03-07 12:23:41 UTC
Created attachment 86628 [details] [review] Bug 22473: flush in psgi - V1 Here we are checking on each request That could work, but do not feel robust Moreover it will not affect scripts outside of plack Created attachment 86629 [details] [review] Bug 22473: Two other places that do not work - V2 Created attachment 86630 [details] [review] Bug 22473: Handle config expiration in C4::Context->new - V3 Created attachment 86631 [details] [review] Bug 22473: Example of watcher to invalidate config cache - V4 Test plan: perl watchfile.pl then update the config Note that we do not handle everything, for instance the DB credentials will not be taken into account. I guess we could call C4::Context->dbh({ new => 1 }) as well. Here are 4 versions (to apply and test separately) that could work. Only the last one (V4) is, in my opinion, viable. Not forgotten about this, it's just in a long queue to take a look.. Thanks for all the alternations to look at Jonathan.. I hope to come back to this soon and take a proper look :) |