Bug 22514

Summary: Hardcoded value of 10 for return hour when calculating hourly loans affected by holidays
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: CirculationAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: gmcharlt, josef.moravec, kyle.m.hall, martin.renvoize, r.delahunty
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:

Description Nick Clemens (kidclamp) 2019-03-14 12:32:06 UTC
From Koha/Calendar.pm:

    if ( $unit eq 'hours' ) {
        # Fixed for legacy support. Should be set as a branch parameter
        my $return_by_hour = 10;

        $dt = $self->addHours($startdate, $add_duration, $return_by_hour);
Comment 1 Katrin Fischer 2023-09-23 21:09:23 UTC
Still valid.
Comment 2 Ray Delahunty 2024-03-04 09:42:47 UTC
Lack of properly working hourly loans functionality in Koha is a major problem for us. To prevent items being due back on weekends, all of our 8 libraries have every weekend day set to be closed days even though the libaries are open, and loaning hundreds of 5 hourly loans daily (mainly laptops). A fix to this bug would help reduce patron confusion with loan periods. But fully working hourly loans needs other fixes including those discussed in bug 6796 and bug 9725. And I suspect others.