Summary: | OPACViewOthersSuggestions if set to Show will only show when patron has made a suggestion | ||
---|---|---|---|
Product: | Koha | Reporter: | Kelly McElligott <kelly> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | 1joynelson, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
20.05.00, 19.11.06, 19.05.11
|
Circulation function: | |
Attachments: |
Bug 22515: Improve logic determining how to show OPAC suggestions
Bug 22515: Improve logic determining how to show OPAC suggestions Bug 22515: Improve logic determining how to show OPAC suggestions |
Description
Kelly McElligott
2019-03-14 14:44:03 UTC
I don't see this behaviour on master. I can access all suggestions from the navigation for my logged in user and logged out. Created attachment 103797 [details] [review] Bug 22515: Improve logic determining how to show OPAC suggestions This patch makes changes to the OPAC suggestions view so that the logic around logged in users and the OPACViewOthersSuggestions preference is more specific. To reproduce the bug you should have pending purchase susggestions in your system from more than one patron. 1. Set the OPACViewOthersSuggestions preference to "Show." 2. Log in to the OPAC as a user who has not submitted any suggestions. 3. Follow the link to the purchase suggestions page from the menu under the search bar. 4. The page will say that there are no purchase suggestions. 5. Add "?suggested_by_anyone=1" to the end of the page URL. 6. You should see suggestions from other users. To test, apply the patch and repeat steps 2-3 above. The suggestions page should show other patrons' suggestions. Test with different combinations of factors: - Logged in user, OPACViewOthersSuggestions off - No logged in user, OPACViewOthersSuggestions on - No logged in user, OPACViewOthersSuggestions off Created attachment 103799 [details] [review] Bug 22515: Improve logic determining how to show OPAC suggestions This patch makes changes to the OPAC suggestions view so that the logic around logged in users and the OPACViewOthersSuggestions preference is more specific. To reproduce the bug you should have pending purchase susggestions in your system from more than one patron. 1. Set the OPACViewOthersSuggestions preference to "Show." 2. Log in to the OPAC as a user who has not submitted any suggestions. 3. Follow the link to the purchase suggestions page from the menu under the search bar. 4. The page will say that there are no purchase suggestions. 5. Add "?suggested_by_anyone=1" to the end of the page URL. 6. You should see suggestions from other users. To test, apply the patch and repeat steps 2-3 above. The suggestions page should show other patrons' suggestions. Test with different combinations of factors: - Logged in user, OPACViewOthersSuggestions off - No logged in user, OPACViewOthersSuggestions on - No logged in user, OPACViewOthersSuggestions off Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 104206 [details] [review] Bug 22515: Improve logic determining how to show OPAC suggestions This patch makes changes to the OPAC suggestions view so that the logic around logged in users and the OPACViewOthersSuggestions preference is more specific. To reproduce the bug you should have pending purchase susggestions in your system from more than one patron. 1. Set the OPACViewOthersSuggestions preference to "Show." 2. Log in to the OPAC as a user who has not submitted any suggestions. 3. Follow the link to the purchase suggestions page from the menu under the search bar. 4. The page will say that there are no purchase suggestions. 5. Add "?suggested_by_anyone=1" to the end of the page URL. 6. You should see suggestions from other users. To test, apply the patch and repeat steps 2-3 above. The suggestions page should show other patrons' suggestions. Test with different combinations of factors: - Logged in user, OPACViewOthersSuggestions off - No logged in user, OPACViewOthersSuggestions on - No logged in user, OPACViewOthersSuggestions off Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work everyone! Pushed to master for 20.05 Backported to 19.11.x for 19.11.06 backported to 19.05.x for 19.05.11 |