Summary: | accountlines.lastincrement can be removed | ||
---|---|---|---|
Product: | Koha | Reporter: | Martin Renvoize <martin.renvoize> |
Component: | Architecture, internals, and plumbing | Assignee: | Martin Renvoize <martin.renvoize> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | josef.moravec, kyle, m.de.rooy, martin.renvoize, nick, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 14591, 21683 | ||
Bug Blocks: | 14825 | ||
Attachments: |
Bug 22516: Remove remaining calls to lastincrement
Bug 22516: Database update Bug 22516: Remove remaining calls to lastincrement Bug 22516: Database update Bug 22516: Remove remaining calls to lastincrement Bug 22516: Database update Bug 22516: Remove remaining calls to lastincrement Bug 22516: Database update |
Description
Martin Renvoize
2019-03-14 17:07:53 UTC
Created attachment 86637 [details] [review] Bug 22516: Remove remaining calls to lastincrement A few places still set lastincrement and the tests still checked for correct values. But nowhere in the code still uses lastincrement for anything meaningful. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 86638 [details] [review] Bug 22516: Database update Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Test plan.. in reality this shouldn't affect anything as the real testing of functionality will have happened in bug 14591. So.. test plan is to simply run the affected tests and make sure they are still passing. Created attachment 86662 [details] [review] Bug 22516: Remove remaining calls to lastincrement A few places still set lastincrement and the tests still checked for correct values. But nowhere in the code still uses lastincrement for anything meaningful. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 86663 [details] [review] Bug 22516: Database update Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 86712 [details] [review] Bug 22516: Remove remaining calls to lastincrement A few places still set lastincrement and the tests still checked for correct values. But nowhere in the code still uses lastincrement for anything meaningful. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 86713 [details] [review] Bug 22516: Database update Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 86888 [details] [review] Bug 22516: Remove remaining calls to lastincrement A few places still set lastincrement and the tests still checked for correct values. But nowhere in the code still uses lastincrement for anything meaningful. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 86889 [details] [review] Bug 22516: Database update Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> @RM: DBIx update ! Awesome work all! Pushed to master for 19.05 Enhancement, will not be backported to 18.11.x series. |