| Summary: | OPAC suggestion form doesn't require mandatory fields | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | jonathan.druart, lucas, martin.renvoize, nick, rajujogi.t |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 13618 | ||
| Bug Blocks: | 22800 | ||
| Attachments: |
Bug 22550: OPAC suggestion form doesn't require mandatory fields
Bug 22550: OPAC suggestion form doesn't require mandatory fields Bug 22550: OPAC suggestion form doesn't require mandatory fields Bug 22550: OPAC suggestion form doesn't require mandatory fields Bug 22550: OPAC suggestion form doesn't require mandatory fields |
||
|
Description
Owen Leonard
2019-03-20 16:16:08 UTC
Created attachment 86823 [details] [review] Bug 22550: OPAC suggestion form doesn't require mandatory fields This patch changes the template filter on the [% mandatoryfields %] template variable. The variable outputs JSON, so it should have the $raw filter. To test suggestions must be enabled in the OPAC. Apply the patch and go to Purchase suggestions -> New suggestion. In the form, required fields should be labeled in red. It should not be possible to submit the form without filling in these fields. Created attachment 86926 [details] [review] Bug 22550: OPAC suggestion form doesn't require mandatory fields Test plan: 1. OPAC->login->your purchase suggestions->New purchase suggestion 2. Click button "Submit your suggestion" directly without filling in any field. Empty suggestion record was added succeffully. 3. Apply the patch. 4. Click button "Submit your suggestion" directly without filling in any field. The required fields should be labeled in red. (you can change the mandatory fields by preference 'OPACSuggestionMandatoryFields') Signed-off-by: Bin Wen <bin.wen@inlibro.com> Created attachment 86942 [details] [review] Bug 22550: OPAC suggestion form doesn't require mandatory fields Test plan: 1. OPAC->login->your purchase suggestions->New purchase suggestion 2. Click button "Submit your suggestion" directly without filling in any field. Empty suggestion record was added succeffully. 3. Apply the patch. 4. Click button "Submit your suggestion" directly without filling in any field. The required fields should be labeled in red. (you can change the mandatory fields by preference 'OPACSuggestionMandatoryFields') Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Jogiraju,T. <rajujogi.t@gmail.com> Created attachment 86943 [details] [review] Bug 22550: OPAC suggestion form doesn't require mandatory fields Test plan: 1. OPAC->login->your purchase suggestions->New purchase suggestion 2. Click button "Submit your suggestion" directly without filling in any field. Empty suggestion record was added succeffully. 3. Apply the patch. 4. Click button "Submit your suggestion" directly without filling in any field. The required fields should be labeled in red. (you can change the mandatory fields by preference 'OPACSuggestionMandatoryFields') Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Jogiraju,T. <rajujogi.t@gmail.com> Signed-off-by: Jogiraju,T. <rajujogi.t@gmail.com> Created attachment 86959 [details] [review] Bug 22550: OPAC suggestion form doesn't require mandatory fields Test plan: 1. OPAC->login->your purchase suggestions->New purchase suggestion 2. Click button "Submit your suggestion" directly without filling in any field. Empty suggestion record was added succeffully. 3. Apply the patch. 4. Click button "Submit your suggestion" directly without filling in any field. The required fields should be labeled in red. (you can change the mandatory fields by preference 'OPACSuggestionMandatoryFields') Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Jogiraju,T. <rajujogi.t@gmail.com> Signed-off-by: Jogiraju,T. <rajujogi.t@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.05 this isn't necessary in 18.05, not backporting |