| Summary: | Add option ItemHoldingLibrary to ReservesControlBranch | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Julian Maurice <julian.maurice> |
| Component: | Hold requests | Assignee: | Julian Maurice <julian.maurice> |
| Status: | In Discussion --- | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | andrew, fridolin.somers, gmcharlt, kohadevinim, nick, pierre.genty |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 22562: Add option ItemHoldingLibrary to ReservesControlBranch
Bug 22562: Add option ItemHoldingLibrary to ReservesControlBranch Bug 22562: Add option ItemHoldingLibrary to ReservesControlBranch Bug 22562: Add option ItemHoldingLibrary to ReservesControlBranch Bug 22562: (follow-up) fix 22.11 |
||
|
Description
Julian Maurice
2019-03-22 12:31:47 UTC
Created attachment 86906 [details] [review] Bug 22562: Add option ItemHoldingLibrary to ReservesControlBranch Test plan: 1. Apply patch 2. Run updatedatabase 3. Set syspref ReservesControlBranch to "item's holding library" 4. Create biblios, items, patrons on different libraries and define circulation (hold) rules for them 5. Verify that these rules are taken into account and that they use the holding library 6. Verify that the behaviour for other values of ReservesControlBranch still work as expected. Created attachment 100273 [details] [review] Bug 22562: Add option ItemHoldingLibrary to ReservesControlBranch Test plan: 1. Apply patch 2. Run updatedatabase 3. Set syspref ReservesControlBranch to "item's holding library" 4. Create biblios, items, patrons on different libraries and define circulation (hold) rules for them 5. Verify that these rules are taken into account and that they use the holding library 6. Verify that the behaviour for other values of ReservesControlBranch still work as expected. We have changed some conflicts Created attachment 100274 [details] [review] Bug 22562: Add option ItemHoldingLibrary to ReservesControlBranch Test plan: 1. Apply patch 2. Run updatedatabase 3. Set syspref ReservesControlBranch to "item's holding library" 4. Create biblios, items, patrons on different libraries and define circulation (hold) rules for them 5. Verify that these rules are taken into account and that they use the holding library 6. Verify that the behaviour for other values of ReservesControlBranch still work as expected. Signed-off-by: Devinim <nazli@devinim.com.tr> Please also change sysprefs.sql to add the option for new installations. Created attachment 120617 [details] [review] Bug 22562: Add option ItemHoldingLibrary to ReservesControlBranch Test plan: 1. Apply patch 2. Run updatedatabase 3. Set syspref ReservesControlBranch to "item's holding library" 4. Create biblios, items, patrons on different libraries and define circulation (hold) rules for them 5. Verify that these rules are taken into account and that they use the holding library 6. Verify that the behaviour for other values of ReservesControlBranch still work as expected. Signed-off-by: Nazlı Çetin <nazli@devinim.com.tr> Rebased on master + added required modification to sysprefs.sql This works, but I have an edge case: Library A - only allow holds from homelibrary Library B - allow holds form any library ReservesControlBranch: ItemsHoldingLibrary Book with homebranch Library A is checked in at Library B, a transfer is set to return the book home and the holdingbranch is set to Library B A patron from library C can place a hold because of the holdingbranch The book arrives at library A and is checked in - the hold does not trigger because the holdingbranch has changed and the rule is now 'only from home library' Created attachment 166965 [details] [review] Bug 22562: (follow-up) fix 22.11 |