Bug 22562

Summary: Add option ItemHoldingLibrary to ReservesControlBranch
Product: Koha Reporter: Julian Maurice <julian.maurice>
Component: Hold requestsAssignee: Julian Maurice <julian.maurice>
Status: In Discussion --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: andrewfh, fridolin.somers, gmcharlt, katrin.fischer, kohadevinim, nick, pierre.genty
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 22562: Add option ItemHoldingLibrary to ReservesControlBranch
Bug 22562: Add option ItemHoldingLibrary to ReservesControlBranch
Bug 22562: Add option ItemHoldingLibrary to ReservesControlBranch
Bug 22562: Add option ItemHoldingLibrary to ReservesControlBranch
Bug 22562: (follow-up) fix 22.11

Description Julian Maurice 2019-03-22 12:31:47 UTC

    
Comment 1 Julian Maurice 2019-03-22 12:34:14 UTC
Created attachment 86906 [details] [review]
Bug 22562: Add option ItemHoldingLibrary to ReservesControlBranch

Test plan:
1. Apply patch
2. Run updatedatabase
3. Set syspref ReservesControlBranch to "item's holding library"
4. Create biblios, items, patrons on different libraries and define
circulation (hold) rules for them
5. Verify that these rules are taken into account and that they use the
holding library
6. Verify that the behaviour for other values of ReservesControlBranch
still work as expected.
Comment 2 Devinim 2020-03-06 14:27:35 UTC
Created attachment 100273 [details] [review]
Bug 22562: Add option ItemHoldingLibrary to ReservesControlBranch

Test plan:
1. Apply patch
2. Run updatedatabase
3. Set syspref ReservesControlBranch to "item's holding library"
4. Create biblios, items, patrons on different libraries and define
circulation (hold) rules for them
5. Verify that these rules are taken into account and that they use the
holding library
6. Verify that the behaviour for other values of ReservesControlBranch
still work as expected.
Comment 3 Devinim 2020-03-06 14:33:22 UTC
We have changed some conflicts
Comment 4 Devinim 2020-03-06 14:36:06 UTC
Created attachment 100274 [details] [review]
Bug 22562: Add option ItemHoldingLibrary to ReservesControlBranch

Test plan:
1. Apply patch
2. Run updatedatabase
3. Set syspref ReservesControlBranch to "item's holding library"
4. Create biblios, items, patrons on different libraries and define
circulation (hold) rules for them
5. Verify that these rules are taken into account and that they use the
holding library
6. Verify that the behaviour for other values of ReservesControlBranch
still work as expected.

Signed-off-by: Devinim <nazli@devinim.com.tr>
Comment 5 Katrin Fischer 2020-07-05 01:31:26 UTC
Please also change sysprefs.sql to add the option for new installations.
Comment 6 Julian Maurice 2021-05-06 12:25:28 UTC
Created attachment 120617 [details] [review]
Bug 22562: Add option ItemHoldingLibrary to ReservesControlBranch

Test plan:
1. Apply patch
2. Run updatedatabase
3. Set syspref ReservesControlBranch to "item's holding library"
4. Create biblios, items, patrons on different libraries and define
circulation (hold) rules for them
5. Verify that these rules are taken into account and that they use the
holding library
6. Verify that the behaviour for other values of ReservesControlBranch
still work as expected.

Signed-off-by: Nazlı Çetin <nazli@devinim.com.tr>
Comment 7 Julian Maurice 2021-05-06 12:27:04 UTC
Rebased on master + added required modification to sysprefs.sql
Comment 8 Nick Clemens (kidclamp) 2021-05-12 13:55:10 UTC
This works, but I have an edge case:

Library A - only allow holds from homelibrary
Library B - allow holds form any library

ReservesControlBranch: ItemsHoldingLibrary

Book with homebranch Library A is checked in at Library B, a transfer is set to return the book home and the holdingbranch is set to Library B

A patron from library C can place a hold because of the holdingbranch

The book arrives at library A and is checked in - the hold does not trigger because the holdingbranch has changed and the rule is now 'only from home library'
Comment 9 Fridolin Somers 2024-03-27 13:27:38 UTC
Needs a rebase since Bug 30085
Comment 10 Fridolin Somers 2024-05-21 12:37:20 UTC
Created attachment 166965 [details] [review]
Bug 22562: (follow-up) fix 22.11