| Summary: | Partially receiving order and adding internal note on invoice updates note on every order on the system | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Janet McGowan <janet.mcgowan> |
| Component: | Acquisitions | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
| Status: | CLOSED FIXED | QA Contact: | Josef Moravec <josef.moravec> |
| Severity: | blocker | ||
| Priority: | P5 - low | CC: | fiona.borthwick, janet.mcgowan, josef.moravec, lucas, martin.renvoize, nick |
| Version: | 18.11 | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 21467 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 22565: Do NOT replace all internalnote's on receive
Bug 22565: Add test for ModReceiveOrder regression Bug 22565: Do NOT replace all internalnote's on receive Bug 22565: Add test for ModReceiveOrder regression Bug 22565: (QA follow-up) Fix test Acquisition.t Bug 22565: (QA follow-up) Fix test Acquisition.t |
||
|
Description
Janet McGowan
2019-03-22 16:14:32 UTC
Data loss bug - updating severity. Looks like this was caused by bug 21467. There's a really clear mistake in the Update statement that's called in that it's missing a WHERE clause... Ooops. Created attachment 86965 [details] [review] Bug 22565: Do NOT replace all internalnote's on receive Bug 21467 introduced a but whereby setting any order_internalnote on receive one would end up setting all orders to have that internalnote. This patch adds the missing WHERE clause to the database query which was likely lost during a rebase? Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 86966 [details] [review] Bug 22565: Add test for ModReceiveOrder regression This test checks that order_internalnote is only updated for the given orderline in ModReceiveOrder. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 86967 [details] [review] Bug 22565: Do NOT replace all internalnote's on receive Bug 21467 introduced a but whereby setting any order_internalnote on receive one would end up setting all orders to have that internalnote. This patch adds the missing WHERE clause to the database query which was likely lost during a rebase? Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 86968 [details] [review] Bug 22565: Add test for ModReceiveOrder regression This test checks that order_internalnote is only updated for the given orderline in ModReceiveOrder. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 86969 [details] [review] Bug 22565: (QA follow-up) Fix test Acquisition.t Test plan: prove t/db_dependent/Acquisition.t should pass Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 86970 [details] [review] Bug 22565: (QA follow-up) Fix test Acquisition.t Test plan: prove t/db_dependent/Acquisition.t should pass Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Thanks Josef, looking good. Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.04 missing dependency for 18.05.x, not backporting. |