| Summary: | Filters on subscription result list search the wrong column | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Séverine Queune <severine.queune> |
| Component: | Serials | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | colin.campbell, jonathan.druart, josef.moravec, lucas, martin.renvoize, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
19.05.00, 18.11.05
|
|
| Circulation function: | |||
| Bug Depends on: | 18426 | ||
| Bug Blocks: | |||
| Attachments: |
Sceenshot 1 - search failed
Sceenshot 1 - search succeed using the fliter of the column on the right Bug 22621: Fix filters on subscription search results Bug 22621: Fix filters on subscription search results Bug 22621: Fix filters on subscription search results |
||
Created attachment 87316 [details]
Sceenshot 1 - search succeed using the fliter of the column on the right
Created attachment 88585 [details] [review] Bug 22621: Fix filters on subscription search results Caused by commit 4e698f7b478a094d7b32ebfeaa917bca05ebcc5b Bug 18426: Allow to edit subscriptions in batch There is a shift caused by a hidden column, which make the filters searching on the previous column. Test plan: - Add 1+ searchable additional field for subscription - Create a new subscription - Search for subscriptions - Use the column filters to filter the results => The results must be filtered accordingly Created attachment 88730 [details] [review] Bug 22621: Fix filters on subscription search results Caused by commit 4e698f7b478a094d7b32ebfeaa917bca05ebcc5b Bug 18426: Allow to edit subscriptions in batch There is a shift caused by a hidden column, which make the filters searching on the previous column. Test plan: - Add 1+ searchable additional field for subscription - Create a new subscription - Search for subscriptions - Use the column filters to filter the results => The results must be filtered accordingly Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Created attachment 88773 [details] [review] Bug 22621: Fix filters on subscription search results Caused by commit 4e698f7b478a094d7b32ebfeaa917bca05ebcc5b Bug 18426: Allow to edit subscriptions in batch There is a shift caused by a hidden column, which make the filters searching on the previous column. Test plan: - Add 1+ searchable additional field for subscription - Create a new subscription - Search for subscriptions - Use the column filters to filter the results => The results must be filtered accordingly Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.05 backported to 18.05.x for 18.05.13 |
Created attachment 87315 [details] Sceenshot 1 - search failed On the serial subscription page result, the filters search the column on its left. Could it be the first column with check box but without filter that create the gap ? See the 2 screenshots attached : - #1 : failed searching "notes" using the filter on "Notes" column - #2 : 1 result (as expected) searching "notes" using the filter on "Library" column