Bug 22631

Summary: Make links on barcode on hold summary page consistent (bug 21070)
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: Hold requestsAssignee: Katrin Fischer <katrin.fischer>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: gmcharlt, martin.renvoize, nick
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 21070    
Bug Blocks:    
Attachments: Bug 22631: Make links on barcode on hold summary page consistent (bug 21070)
Bug 22631: Make links on barcode on hold summary page consistent (bug 21070)
Bug 22631: Make links on barcode on hold summary page consistent (bug 21070)
Bug 22631: Make links on barcode on hold summary page consistent (bug 21070)

Description Katrin Fischer 2019-04-03 19:25:26 UTC
Bug 21070 changed the link on the holds summary so the barcode would link to the item on moredetail for an item level hold.

If a hold is already waiting, the link still goes to the detail page of the record.
Comment 1 Katrin Fischer 2019-04-03 19:32:03 UTC
Created attachment 87371 [details] [review]
Bug 22631: Make links on barcode on hold summary page consistent (bug 21070)

Bug 21070 changed the link on the holds summary so the barcode
would link to the item on moredetail for an item level hold.

If a hold is already waiting, the link still goes to the detail
page of the record. This patch changes it so the barcode always
links to the item.

To test:
- Place some item level holds on a record
- Verify the barcodes on the hold summary page link to
  moredetail.pl
- Return one of the items so that the hold is waiting
- Verify the barcode links to the record detail page now
- Apply patch
- Verify barcodes for pending and waiting holds now both
  link to moredetail.pl
Comment 2 Owen Leonard 2019-04-04 12:10:49 UTC
Created attachment 87408 [details] [review]
Bug 22631: Make links on barcode on hold summary page consistent (bug 21070)

Bug 21070 changed the link on the holds summary so the barcode
would link to the item on moredetail for an item level hold.

If a hold is already waiting, the link still goes to the detail
page of the record. This patch changes it so the barcode always
links to the item.

To test:
- Place some item level holds on a record
- Verify the barcodes on the hold summary page link to
  moredetail.pl
- Return one of the items so that the hold is waiting
- Verify the barcode links to the record detail page now
- Apply patch
- Verify barcodes for pending and waiting holds now both
  link to moredetail.pl

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Bin Wen 2019-04-05 17:47:07 UTC
Created attachment 87453 [details] [review]
Bug 22631: Make links on barcode on hold summary page consistent (bug 21070)

Bug 21070 changed the link on the holds summary so the barcode
would link to the item on moredetail for an item level hold.

If a hold is already waiting, the link still goes to the detail
page of the record. This patch changes it so the barcode always
links to the item.

To test:
- Place some item level holds on a record
- Verify the barcodes on the hold summary page link to
  moredetail.pl
- Return one of the items so that the hold is waiting
- Verify the barcode links to the record detail page now
- Apply patch
- Verify barcodes for pending and waiting holds now both
  link to moredetail.pl

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Bin Wen <bin.wen@inlibro.com>
Comment 4 Martin Renvoize 2019-04-08 11:46:52 UTC
Created attachment 87506 [details] [review]
Bug 22631: Make links on barcode on hold summary page consistent (bug 21070)

Bug 21070 changed the link on the holds summary so the barcode
would link to the item on moredetail for an item level hold.

If a hold is already waiting, the link still goes to the detail
page of the record. This patch changes it so the barcode always
links to the item.

To test:
- Place some item level holds on a record
- Verify the barcodes on the hold summary page link to
  moredetail.pl
- Return one of the items so that the hold is waiting
- Verify the barcode links to the record detail page now
- Apply patch
- Verify barcodes for pending and waiting holds now both
  link to moredetail.pl

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Bin Wen <bin.wen@inlibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize 2019-04-08 11:47:16 UTC
Nice fix, no regressions.. PQA
Comment 6 Nick Clemens (kidclamp) 2019-04-11 13:58:21 UTC
Awesome work all!

Pushed to master for 19.05
Comment 7 Martin Renvoize 2019-04-15 17:44:57 UTC
Enhancement, will not be backported to 18.11.x series.