Bug 22633

Summary: Barcodes in the patrons 'holds' summary should link to the moredetail page
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: Hold requestsAssignee: Katrin Fischer <katrin.fischer>
Status: RESOLVED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: minor    
Priority: P5 - low CC: axel.amghar, chris, fridolin.somers, gmcharlt, lisetteslatah, m.de.rooy, martin.renvoize
Version: master   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21070
Change sponsored?: --- Patch complexity: Trivial patch
Who signed the patch off: Text to go in the release notes:
Version(s) released in:
19.11.00,19.05.01
Attachments: Bug 22633: Link barcodes in hold summary in patron account to moredetail page
Bug 22633: Link barcodes in hold summary in patron account to moredetail page
Bug 22633: Link barcodes in hold summary in patron account to moredetail page
Bug 22633: Link barcodes in hold summary in patron account to moredetail page

Description Katrin Fischer 2019-04-03 19:45:46 UTC
Bug 21070 links the barcode on holds to the item on moredetail.pl. We should make the same change to the hold lists in the staff patron account.
Comment 1 Katrin Fischer 2019-04-03 20:00:16 UTC
Created attachment 87372 [details] [review]
Bug 22633: Link barcodes in hold summary in patron account to moredetail page

Bug 21070 links the barcode on holds to the item on moredetail.pl.
This patch makes the same change to the hold lists in the staff
patron account.

To test:
- Create some holds, have at least
  - one item level hold
  - one hold waiting for pick-up
- Take a look at the details and checkouts tabs
  in the patron account on staff side
- Verify that the barcodes link to the record detail page
- Apply patch
- Verify the barcodes now link to the moredetail page
Comment 2 axel 2019-04-10 14:43:59 UTC
Created attachment 87725 [details] [review]
Bug 22633: Link barcodes in hold summary in patron account to moredetail page

Bug 21070 links the barcode on holds to the item on moredetail.pl.
This patch makes the same change to the hold lists in the staff
patron account.

To test:
- Create some holds, have at least
  - one item level hold
  - one hold waiting for pick-up
- Take a look at the details and checkouts tabs
  in the patron account on staff side
- Verify that the barcodes link to the record detail page
- Apply patch
- Verify the barcodes now link to the moredetail page

Signed-off-by: Axel Amghar <axel.amghar@gmail.com>
Comment 3 Chris Cormack 2019-04-14 23:42:22 UTC
There's a conflict in the js now
Comment 4 Katrin Fischer 2019-05-11 21:20:17 UTC
Created attachment 89620 [details] [review]
Bug 22633: Link barcodes in hold summary in patron account to moredetail page

Bug 21070 links the barcode on holds to the item on moredetail.pl.
This patch makes the same change to the hold lists in the staff
patron account.

To test:
- Create some holds, have at least
  - one item level hold
  - one hold waiting for pick-up
- Take a look at the details and checkouts tabs
  in the patron account on staff side
- Verify that the barcodes link to the record detail page
- Apply patch
- Verify the barcodes now link to the moredetail page

Signed-off-by: Axel Amghar <axel.amghar@gmail.com>
Comment 5 Marcel de Rooy 2019-05-31 09:33:36 UTC
Created attachment 90219 [details] [review]
Bug 22633: Link barcodes in hold summary in patron account to moredetail page

Bug 21070 links the barcode on holds to the item on moredetail.pl.
This patch makes the same change to the hold lists in the staff
patron account.

To test:
- Create some holds, have at least
  - one item level hold
  - one hold waiting for pick-up
- Take a look at the details and checkouts tabs
  in the patron account on staff side
- Verify that the barcodes link to the record detail page
- Apply patch
- Verify the barcodes now link to the moredetail page

Signed-off-by: Axel Amghar <axel.amghar@gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Martin Renvoize 2019-06-13 11:51:42 UTC
Nice work!

Pushed to master for 19.11.00
Comment 7 Fridolin SOMERS 2019-06-20 12:21:02 UTC
Pushed to 19.05.x for 19.05.01