| Summary: | Typo in SQL in smart-rules.pl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Circulation | Assignee: | Katrin Fischer <katrin.fischer> |
| Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | gmcharlt, kyle, martin.renvoize |
| Version: | 18.11 | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
18.11.05
|
|
| Circulation function: | |||
| Attachments: |
Bug 22648: Fix typo in SQL in smart-rules.pl
Bug 22648: Fix typo in SQL in smart-rules.pl |
||
|
Description
Nick Clemens (kidclamp)
2019-04-05 16:59:41 UTC
Created attachment 87469 [details] [review] Bug 22648: Fix typo in SQL in smart-rules.pl Fixes 2 SQL statements for setting the maximum number of checkouts possible. To test: - In 18.11 - Verify that setting Default checkout, hold and return policy works - Verfiy that setting Default checkout, ohld and return policy by patron category works Just did some testing in our 18.11 installation and it doesn't blow up? I 'think' this is only an issue if you're running in SQL strict modes.. it'll be a nice thing to fix, but hopefully in the wild it's not really causing any problems. Created attachment 87489 [details] [review] Bug 22648: Fix typo in SQL in smart-rules.pl Fixes 2 SQL statements for setting the maximum number of checkouts possible. To test: - In 18.11 - Verify that setting Default checkout, hold and return policy works - Verfiy that setting Default checkout, ohld and return policy by patron category works Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signing off. Going straight for PQA as it's a trivial patch.. thanks for reporting Nick and thanks for the quick patch Katrin. Pushed to 18.11.x for 18.11.05. |