| Summary: | Editing Course reserves is broken | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | Course reserves | Assignee: | Koha Team University Lyon 3 <koha> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | fridolin.somers, hayleypelham, koha, lucas, martin.renvoize, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
19.05.00, 18.11.05, 18.05.12, 17.11.18
|
|
| Circulation function: | |||
| Bug Depends on: | 10382 | ||
| Bug Blocks: | 22630 | ||
| Attachments: |
BUG 22652- Editing Course reserves is broken
Bug 22652 - Editing Course reserves is broken Bug 22652 - Editing Course reserves is broken Bug 22652 - Editing Course reserves is broken Bug 22652 - Editing Course reserves is broken |
||
|
Description
Katrin Fischer
2019-04-06 18:31:06 UTC
Created attachment 87752 [details] BUG 22652- Editing Course reserves is broken I'm not really used to create patches and I've done this one on a 17.11.13 koha version. But it corrects this issue in our install. Sonia Created attachment 87756 [details] [review] Bug 22652 - Editing Course reserves is broken I don't think this patch is working in master, but I'm not sure I'm understanding the bug correctly. I've reattached the patch in a corrected format so that someone else can take a look. Thanks Owen!
I've tested it on a sandbox and it works :) But, it's perhaps better if someone else sign it off.
You could follow this test plan :
1. Create a course reserve or go on an existing one
2. Add items and add a change for the holdingbranch
3. On the list of items in this course reserve (course_reserves/course-details.pl?course_id=xx), click on "edit" at the end of a row :
> without the patch, you can't see the holdingbranch you have choose for this item, but you see "LEAVE UNCHANGED"
>with the patch, you can see the holdingbranch you have choose when adding this item in the course
Created attachment 87763 [details] [review] Bug 22652 - Editing Course reserves is broken Signed-off-by: Liz Rea <wizzyrea@gmail.com> I saw the problem, patch resolves it Looks like Liz signed this off, changing status to Signed Off. Created attachment 87936 [details] [review] Bug 22652 - Editing Course reserves is broken Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> Created attachment 87968 [details] [review] Bug 22652 - Editing Course reserves is broken To test: 1. Create a course reserve or go on an existing one 2. Add items and add a change for the holdingbranch 3. On the list of items in this course reserve (course_reserves/course-details.pl?course_id=xx), click on "edit" at the end of a row : Without the patch, you can't see the holdingbranch you have choose for this item, but you see "LEAVE UNCHANGED" With the patch, you can see the holdingbranch you have choose when adding this item in the course Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> I think that fixes part of the problem I saw - will retest and file separate bugs if necessary later. Thx Sonia! Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.05 backported to 18.05.x for 18.05.12 Pushed to 17.11.x for 17.11.18 |