Summary: | SCO broken on invalid barcodes | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | Self checkout | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | major | ||
Priority: | P5 - low | CC: | josef.moravec, kyle, martin.renvoize, nick, wizzyrea |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
19.05.00
|
Circulation function: | |
Bug Depends on: | 21206 | ||
Bug Blocks: | |||
Attachments: |
Bug 22675: Fix SCO behaviour on non-existent barcodes
Bug 22675: Fix SCO behaviour on non-existent barcodes Bug 22675: Fix SCO behaviour on non-existent barcodes Bug 22675: Fix SCO behaviour on non-existent barcodes |
Description
Tomás Cohen Arazi (tcohen)
2019-04-09 18:57:51 UTC
Created attachment 87672 [details] [review] Bug 22675: Fix SCO behaviour on non-existent barcodes Bug 21206 replaced GetItem for Koha::Items->find, and introduced this problem. This patch verifies $item is defined before attempting to use its methods. To test: - Log into SCO - Type an invalid barcode => FAIL: Things explode :-/ - Apply this patch, reload - Type an invalid barcode => SUCCESS: A nice error message is displayed :-D - Sign off :-D Created attachment 87684 [details] [review] Bug 22675: Fix SCO behaviour on non-existent barcodes Bug 21206 replaced GetItem for Koha::Items->find, and introduced this problem. This patch verifies $item is defined before attempting to use its methods. To test: - Log into SCO - Type an invalid barcode => FAIL: Things explode :-/ - Apply this patch, reload - Type an invalid barcode => SUCCESS: A nice error message is displayed :-D - Sign off :-D Signed-off-by: Liz Rea <wizzyrea@gmail.com> 100% that used to explode, and now does not. Excellent. 100% that used to explode, and now does not. Excellent. 100% that used to explode, and now does not. Excellent. 100% that used to explode, and now does not. Excellent. 100% that used to explode, and now does not. Excellent. 100% that used to explode, and now does not. Excellent. 100% that used to explode, and now does not. Excellent. 100% that used to explode, and now does not. Excellent. 100% that used to explode, and now does not. Excellent. 100% that used to explode, and now does not. Excellent. Created attachment 87685 [details] [review] Bug 22675: Fix SCO behaviour on non-existent barcodes Bug 21206 replaced GetItem for Koha::Items->find, and introduced this problem. This patch verifies $item is defined before attempting to use its methods. To test: - Log into SCO - Type an invalid barcode => FAIL: Things explode :-/ - Apply this patch, reload - Type an invalid barcode => SUCCESS: A nice error message is displayed :-D - Sign off :-D Signed-off-by: Liz Rea <wizzyrea@gmail.com> I laughed so hard at myself I scared my dog. Created attachment 87702 [details] [review] Bug 22675: Fix SCO behaviour on non-existent barcodes Bug 21206 replaced GetItem for Koha::Items->find, and introduced this problem. This patch verifies $item is defined before attempting to use its methods. To test: - Log into SCO - Type an invalid barcode => FAIL: Things explode :-/ - Apply this patch, reload - Type an invalid barcode => SUCCESS: A nice error message is displayed :-D - Sign off :-D Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 19.05 Bug in enhancement not in 18.11.x series |