Bug 22691

Summary: Problem with holds when ExpireReservesMaxPickUpDelay is active
Product: Koha Reporter: Patrick Robitaille <patrick.robitaille>
Component: Hold requestsAssignee: Bugs List <koha-bugs>
Status: RESOLVED INVALID QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: gmcharlt, katrin.fischer, marjorie.barry-vila
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:

Description Patrick Robitaille 2019-04-11 20:07:29 UTC
Hi, 

It seems that there is a problem affecting reservations set aside. The ExpireReservesMaxPickUpDelay preference, when it is active, does not seem to take into account the delay in the ReservesMaxPickUpDelay system preference which determines the time period for which reservations will be available for pickup by the users who made the reservation. However, the reservation is to be canceled during the night the item gets the status « is waiting here ».

To test:
Enable the ExpireReservesMaxPickUpDelay system preference to « Allow»;
Enter a number in the ReservesMaxPickUpDelay system preference to more than 2 days;
Reserve a item for a user;
Return this item to get the hold found message and confirm this reservation;
Wait until the next day and note that the reservation is cleared from the user's account and the record as well;

So the limit of days specified in the ReservesMaxPickUpDelay system preference is not taken into account as indicated.

Can it be the cron job that makes this cancellation? Or it turns out that it is the relationship between the two preferences that is not done correctly?

Thanks, Patrick.
Comment 1 Katrin Fischer 2019-11-24 22:01:53 UTC
Hi Patrick, is this bug still happening for you?
Could you check the expirationdate of the waiting hold in the reserves table? This should be the date calculated for pickup from ExpireReservesMaxPickUpDelay and the day the hold is cancelld by the cronjob if not picked up.
Comment 2 Katrin Fischer 2023-09-23 22:05:16 UTC
I believe this might have been due to how the cancel_expired_holds.pl had been set up.