Bug 22693

Summary: ILL "Price paid" column does not appear in column configuration
Product: Koha Reporter: Andrew Isherwood <bugzilla>
Component: ILLAssignee: Jacob O'Mara <jacob.omara>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: normal    
Priority: P5 - low CC: arthur.suzuki, david, hc, jacob.omara, josef.moravec, lucas, martin.renvoize, pm, wainuiwitikapark
Version: masterKeywords: Academy
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
This adds the "Price paid" column to the inter-library loan requests table. This column is also configurable using the Columns button and in the table settings (Administration > Additional parameters > Table settings > Interlibrary loans > ill-requests).
Version(s) released in:
23.05.00,22.11.03,22.05.11, 21.11.19
Bug Depends on: 22121    
Bug Blocks:    
Attachments: Bug 22693: ILL "Price paid" column does not appear in column configuration
Bug 22693: ILL "Price paid" column does not appear in column configuration
Bug 22693: ILL "Price paid" column does not appear in column configuration
Bug 22693: ILL "Price paid" column does not appear in column configuration
Bug 22693: ILL "Price paid" column does not appear in column configuration

Description Andrew Isherwood 2019-04-12 10:03:14 UTC
"Price paid" was added in bug 22121, it seems I forgot to add it to the column configuration list. Doh.
Comment 1 Holly 2022-10-03 09:35:53 UTC
Just adding a comment to express that there is interest in seeing this feature added.
Comment 2 Patrick 2022-10-20 11:46:03 UTC
The 'Price Paid' field should be viewable and exportable (i.e. included in the output from the export function) in the ILL Requests screen.
This is the functionality of the other columns in the table
Comment 3 Jacob O'Mara 2023-01-09 10:38:54 UTC
Created attachment 145137 [details] [review]
Bug 22693: ILL "Price paid" column does not appear in column configuration

Test Plan:
 - Navigate to ILL requests page from the main menu after setting up your ILL backend.
 - Observe that Price Paid column does not exist either here nor in the column configuration.
 - Apply patch
 - Observe that Price Paid column now appears in ILL requests table and in the column configuration page.
Comment 4 David Nind 2023-01-09 11:23:50 UTC
Created attachment 145138 [details] [review]
Bug 22693: ILL "Price paid" column does not appear in column configuration

Test Plan:
 - Navigate to ILL requests page from the main menu after setting up your ILL backend.
 - Observe that Price Paid column does not exist either here nor in the column configuration.
 - Apply patch
 - Observe that Price Paid column now appears in ILL requests table and in the column configuration page.

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2023-01-09 11:32:55 UTC
Hi Jacob.

One minor thing that needs fixing - the column title should be in sentence case, so "Price paid" instead of "Price Paid".

I've also added a draft release note.

David

Testing notes (using KTD):

1. I enabled the FreeForm backend using the instructions at https://wiki.koha-community.org/wiki/ILL_backends
Comment 7 Jacob O'Mara 2023-01-09 12:04:55 UTC
Created attachment 145140 [details] [review]
Bug 22693: ILL "Price paid" column does not appear in column configuration

Test Plan:
 - Navigate to ILL requests page from the main menu after setting up your ILL backend.
 - Observe that Price Paid column does not exist either here nor in the column configuration.
 - Apply patch
 - Observe that Price Paid column now appears in ILL requests table and in the column configuration page.
Comment 8 Jacob O'Mara 2023-01-09 12:09:22 UTC
Hi David, 

Thanks for the above, casing has been amended on the column and the commit has been reattached.

Jacob
Comment 9 Katrin Fischer 2023-01-09 13:32:00 UTC
I just filed a bug about the missing price formatting - it might apply to this column as well (maybe a new bug?) 
Bug 32595 - Price format cost in ILL requests table
Comment 10 David Nind 2023-01-09 20:01:05 UTC
(In reply to Jacob O'Mara from comment #8)
> Hi David, 
> 
> Thanks for the above, casing has been amended on the column and the commit
> has been reattached.
> 
> Jacob

Thanks Jacob!
Comment 11 David Nind 2023-01-09 23:41:22 UTC
(In reply to Katrin Fischer from comment #9)
> I just filed a bug about the missing price formatting - it might apply to
> this column as well (maybe a new bug?) 
> Bug 32595 - Price format cost in ILL requests table

Can confirm that the formatting of the price paid doesn't change for any of the PriceFormat system preference options.
Comment 12 Martin Renvoize 2023-01-27 15:50:08 UTC
Hmm, bug 22121 which this bug depends upon appears to claim it fixes the price formatting.
Comment 13 Martin Renvoize 2023-01-27 15:54:37 UTC
OK.. I take that back.. the code has completely changed since bug 22121 as far as I can tell.
Comment 14 Martin Renvoize 2023-01-27 15:58:44 UTC
I don't think we should hold this bug up with the formatting issue.. that should go into your formatting bug Katrin and we should expand your bug to catch all prices in the table.
Comment 15 Katrin Fischer 2023-01-27 18:19:17 UTC
(In reply to Martin Renvoize from comment #14)
> I don't think we should hold this bug up with the formatting issue.. that
> should go into your formatting bug Katrin and we should expand your bug to
> catch all prices in the table.

Sounds good!
Comment 16 Katrin Fischer 2023-02-10 23:35:32 UTC
Created attachment 146527 [details] [review]
Bug 22693: ILL "Price paid" column does not appear in column configuration

Test Plan:
 - Navigate to ILL requests page from the main menu after setting up your ILL backend.
 - Observe that Price Paid column does not exist either here nor in the column configuration.
 - Apply patch
 - Observe that Price Paid column now appears in ILL requests table and in the column configuration page.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 17 Katrin Fischer 2023-02-10 23:36:43 UTC
Added David's sign-off line since he was the one who switched to sign-off. 
Thanks Jakob!
Comment 18 Tomás Cohen Arazi 2023-02-15 12:34:22 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 19 Pedro Amorim 2023-02-16 10:35:00 UTC
Nice work everyone!

Pushed to 22.11.x for next release
Comment 20 Lucas Gass 2023-03-01 13:59:12 UTC
Backported to 22.05.x for upcoming 22.05.11
Comment 21 Arthur Suzuki 2023-03-29 08:53:32 UTC
applied to 21.11.x for 21.11.19
Comment 22 wainuiwitikapark 2023-04-27 03:54:07 UTC
Not backported to 21.05.x