| Summary: | ILL "Price paid" column does not appear in column configuration | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Andrew Isherwood <bugzilla> |
| Component: | ILL | Assignee: | Jacob O'Mara <jacob.omara> |
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | arthur.suzuki, david, hc, jacob.omara, josef.moravec, lucas, martin.renvoize, pm, wainuiwitikapark |
| Version: | Main | Keywords: | Academy |
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This adds the "Price paid" column to the inter-library loan requests table. This column is also configurable using the Columns button and in the table settings (Administration > Additional parameters > Table settings > Interlibrary loans > ill-requests).
|
Version(s) released in: |
23.05.00,22.11.03,22.05.11, 21.11.19
|
| Circulation function: | |||
| Bug Depends on: | 22121 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 22693: ILL "Price paid" column does not appear in column configuration
Bug 22693: ILL "Price paid" column does not appear in column configuration Bug 22693: ILL "Price paid" column does not appear in column configuration Bug 22693: ILL "Price paid" column does not appear in column configuration Bug 22693: ILL "Price paid" column does not appear in column configuration |
||
|
Description
Andrew Isherwood
2019-04-12 10:03:14 UTC
Just adding a comment to express that there is interest in seeing this feature added. The 'Price Paid' field should be viewable and exportable (i.e. included in the output from the export function) in the ILL Requests screen. This is the functionality of the other columns in the table Created attachment 145137 [details] [review] Bug 22693: ILL "Price paid" column does not appear in column configuration Test Plan: - Navigate to ILL requests page from the main menu after setting up your ILL backend. - Observe that Price Paid column does not exist either here nor in the column configuration. - Apply patch - Observe that Price Paid column now appears in ILL requests table and in the column configuration page. Created attachment 145138 [details] [review] Bug 22693: ILL "Price paid" column does not appear in column configuration Test Plan: - Navigate to ILL requests page from the main menu after setting up your ILL backend. - Observe that Price Paid column does not exist either here nor in the column configuration. - Apply patch - Observe that Price Paid column now appears in ILL requests table and in the column configuration page. Signed-off-by: David Nind <david@davidnind.com> Hi Jacob. One minor thing that needs fixing - the column title should be in sentence case, so "Price paid" instead of "Price Paid". I've also added a draft release note. David Testing notes (using KTD): 1. I enabled the FreeForm backend using the instructions at https://wiki.koha-community.org/wiki/ILL_backends Created attachment 145140 [details] [review] Bug 22693: ILL "Price paid" column does not appear in column configuration Test Plan: - Navigate to ILL requests page from the main menu after setting up your ILL backend. - Observe that Price Paid column does not exist either here nor in the column configuration. - Apply patch - Observe that Price Paid column now appears in ILL requests table and in the column configuration page. Hi David, Thanks for the above, casing has been amended on the column and the commit has been reattached. Jacob I just filed a bug about the missing price formatting - it might apply to this column as well (maybe a new bug?) Bug 32595 - Price format cost in ILL requests table (In reply to Jacob O'Mara from comment #8) > Hi David, > > Thanks for the above, casing has been amended on the column and the commit > has been reattached. > > Jacob Thanks Jacob! (In reply to Katrin Fischer from comment #9) > I just filed a bug about the missing price formatting - it might apply to > this column as well (maybe a new bug?) > Bug 32595 - Price format cost in ILL requests table Can confirm that the formatting of the price paid doesn't change for any of the PriceFormat system preference options. Hmm, bug 22121 which this bug depends upon appears to claim it fixes the price formatting. OK.. I take that back.. the code has completely changed since bug 22121 as far as I can tell. I don't think we should hold this bug up with the formatting issue.. that should go into your formatting bug Katrin and we should expand your bug to catch all prices in the table. (In reply to Martin Renvoize from comment #14) > I don't think we should hold this bug up with the formatting issue.. that > should go into your formatting bug Katrin and we should expand your bug to > catch all prices in the table. Sounds good! Created attachment 146527 [details] [review] Bug 22693: ILL "Price paid" column does not appear in column configuration Test Plan: - Navigate to ILL requests page from the main menu after setting up your ILL backend. - Observe that Price Paid column does not exist either here nor in the column configuration. - Apply patch - Observe that Price Paid column now appears in ILL requests table and in the column configuration page. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Added David's sign-off line since he was the one who switched to sign-off. Thanks Jakob! Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to 22.11.x for next release Backported to 22.05.x for upcoming 22.05.11 applied to 21.11.x for 21.11.19 Not backported to 21.05.x |