Bug 22697

Summary: Reindent catalogue/result.tt
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: RESOLVED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: martin.renvoize, nick, testopia
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Who signed the patch off: Text to go in the release notes:
Version(s) released in:
19.05.00
Bug Depends on: 22695    
Bug Blocks:    
Attachments: Bug 22697: Reindent catalogue/result.tt
Bug 22697: Reindent catalogue/result.tt
Bug 22697: Reindent catalogue/result.tt

Description Owen Leonard 2019-04-12 14:32:16 UTC
The template for catalog search results in the staff client would be much more readable if it were indented consistently.
Comment 1 Owen Leonard 2019-04-12 14:42:56 UTC Comment hidden (obsolete)
Comment 2 Michal Denar 2019-04-14 12:34:58 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2019-04-17 05:52:15 UTC
Created attachment 88131 [details] [review]
Bug 22697: Reindent catalogue/result.tt

This patch reindents the template for staff client catalogue search
results. The only non-whitespace changes are comments to help identify
closing tags and template directives.

To test, apply the patch and perform a catalog search in the staff
client. The results should look correct.

The diff using the '-w' flag to ignore whitespace should
highlight only moved lines and added comments.

Signed-off-by: Michal Denar <black23@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

https://bugs.koha-community.org/show_bug.cgi?id=22679
Comment 4 Nick Clemens 2019-04-19 14:56:47 UTC
Awesome work all!

Pushed to master for 19.05
Comment 5 Martin Renvoize 2019-04-26 14:20:49 UTC
Enhancement will not be backported to 18.11.x series.