Description
Lucas Gass
2019-04-12 22:50:21 UTC
Created attachment 87940 [details] [review] Attachment to Bug 22702 - circulation note on patron page should allow for HTML tags Bug 22702: circulation note on patron page should allow for HTML tags TEST PLAN: 1. add a circulation note to a patron account that includes some HTML tags like: <p>TEST</p> 2. visit the check out page and notice the tags display literally 3. visit the details page and notice the tags display literally 4. apply patch 5. look again at the check out and details pages and notice the notes rendering HTML Patch tested with a sandbox, by Séverine QUEUNE <severine.queune@bulac.fr> Created attachment 88009 [details] [review] Bug 22702: circulation note on patron page should allow for HTML tags Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Works fine for the 2 pages mentionned, and also for the "Search patrons" result page. Thanks Lucas ! Created attachment 88115 [details] [review] Bug 22702: circulation note on patron page should allow for HTML tags Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Works as described and appears to catch every place the note is displayed. I do have 2 concerns: - Consistency: Why allow HTML in the circulation note, but not in the OPAC note? - Using "" for example by using a class or similar will break the patron search. Leaving it to RM! :) Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.05 not needed in 18.05.x, no backport |