Summary: | Change default value of Elasticsearch cxn_pool to 'Static' | ||
---|---|---|---|
Product: | Koha | Reporter: | Julian Maurice <julian.maurice> |
Component: | Searching - Elasticsearch | Assignee: | Bugs List <koha-bugs> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | major | ||
Priority: | P5 - low | CC: | alex.arnaud, jonathan.druart, martin.renvoize, nick, wizzyrea |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.05.00, 18.11.06
|
|
Circulation function: | |||
Bug Depends on: | 21974 | ||
Bug Blocks: | 26260 | ||
Attachments: |
Bug 22705: Change default value of cxn_pool to 'Static'
Bug 22705: Change default value of cxn_pool to 'Static' Bug 22705: Change default value of cxn_pool to 'Static' |
Description
Julian Maurice
2019-04-15 09:13:06 UTC
Okay, so I re-read https://wiki.koha-community.org/wiki/Elasticsearch and it's clear that the problem comes from the Sniff CxnPool, I changed $KOHA_CONF to use the Static CxnPool, and it works. Shouldn't we use Static as the default CxnPool ? Could this be related to Bug 21974? Just going by keywords :) (In reply to Katrin Fischer from comment #2) > Could this be related to Bug 21974? Just going by keywords :) That is totally related. I'm just complaining about the default value of cxn_pool :) Sniff (Koha's default) works only with a local ES, while Static (Search::Elasticsearch's default) works in most cases. Created attachment 89781 [details] [review] Bug 22705: Change default value of cxn_pool to 'Static' 'Static' is the default value of Search::Elasticsearch and for a good reason : it works in most cases, unlike the 'Sniff' option Created attachment 89897 [details] [review] Bug 22705: Change default value of cxn_pool to 'Static' 'Static' is the default value of Search::Elasticsearch and for a good reason : it works in most cases, unlike the 'Sniff' option To test: 1 - Apply patch 2 - Edit koha-conf.xml 3 - Add '<cxn_pool>Static</cxn_pool>' to the elasticsearch stanza 4 - Restart all the things! 5 - Reindex ES, it works 6 - Set SearchEngine to ES, try searching 7 - It works! Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 90033 [details] [review] Bug 22705: Change default value of cxn_pool to 'Static' 'Static' is the default value of Search::Elasticsearch and for a good reason : it works in most cases, unlike the 'Sniff' option To test: 1 - Apply patch 2 - Edit koha-conf.xml 3 - Add '<cxn_pool>Static</cxn_pool>' to the elasticsearch stanza 4 - Restart all the things! 5 - Reindex ES, it works 6 - Set SearchEngine to ES, try searching 7 - It works! Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.06 I'm declining this for the 18.05 track, as there aren't probably many users using ES, and I want people to have a reason to upgrade. You can feel free to try and convince me to do something different. :) Cheers, Liz |