Bug 22712

Summary:	Funds from inactive budgets appear on Item details if using MarcItemFieldstoOrder
Product:	Koha	Reporter:	Kelly McElligott <kelly>
Component:	Acquisitions	Assignee:	Nick Clemens (kidclamp) <nick>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	normal
Priority:	P5 - low	CC:	fridolin.somers, laura, lucas, nick, oleonard, sbrown, tomascohen, victor
Version:	Main	Keywords:	rel_23_11_candidate
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	23.11.00,23.05.06,22.11.12
Circulation function:
Attachments:	drop down Bug 22712: Make 'Show inactive funds' button on addorderiso2907.pl work for item budgets Bug 22712: Make 'Show inactive funds' button on addorderiso2907.pl work for item budgets Bug 22712: Make 'Show inactive funds' button on addorderiso2907.pl work for item budgets

Description Kelly McElligott 2019-04-16 10:24:11 UTC

Created attachment 88047 [details]
drop down

Bug 14850 has been fixed and patched for 18.11.  This removes the ability to see inactive funds when allocating orders to these funds from an inactive budget. However, if a library is using the system preference MarcItemFieldstoOrder, all the funds will appear in the drop-down menu for that item record.

Comment 1 Katrin Fischer 2019-11-24 22:04:57 UTC

Could this have been related to bug 20014?

Comment 2 Sara Brown 2022-12-08 23:32:35 UTC

This appears to still be relevant as of 22.05.05.

Comment 3 Katrin Fischer 2023-09-23 22:08:33 UTC

Nick, maybe you can tell if this has been fixed?

Comment 4 Nick Clemens (kidclamp) 2023-10-23 19:58:28 UTC

Created attachment 157691 [details] [review]
Bug 22712: Make 'Show inactive funds' button on addorderiso2907.pl work for item budgets

This requires enabling MarcItemFieldsToOrder, see bug 34645

Add an inactive Budget and some funds to your system

Import a file with multiple biblios

Confirm the button hids/displays the funds for all item orders

Comment 5 Lucas Gass (lukeg) 2023-10-24 17:07:28 UTC

Created attachment 157751 [details] [review]
Bug 22712: Make 'Show inactive funds' button on addorderiso2907.pl work for item budgets

This requires enabling MarcItemFieldsToOrder, see bug 34645

Add an inactive Budget and some funds to your system

Import a file with multiple biblios

Confirm the button hids/displays the funds for all item orders

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Comment 6 Katrin Fischer 2023-10-29 10:38:37 UTC

I think it would be nicer if we also had the option here to see the option groups with the budgets. But this fixes the immediate problem of the inactive funds showing.

Comment 7 Katrin Fischer 2023-10-29 10:41:49 UTC

Created attachment 158036 [details] [review]
Bug 22712: Make 'Show inactive funds' button on addorderiso2907.pl work for item budgets

This requires enabling MarcItemFieldsToOrder, see bug 34645

Add an inactive Budget and some funds to your system

Import a file with multiple biblios

Confirm the button hids/displays the funds for all item orders

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 8 Tomás Cohen Arazi (tcohen) 2023-10-30 12:02:58 UTC

Pushed to master for 23.11.

Nice work everyone, thanks!

Comment 9 Laura O'Neil 2023-11-06 13:48:13 UTC

Can this be backported to 23.05?

Comment 10 Fridolin Somers 2023-11-08 08:17:02 UTC

Pushed to 23.05.x for 23.05.06

Comment 11 Matt Blenkinsop 2023-11-13 15:29:02 UTC

Nice work everyone!

Pushed to oldstable for 22.11.x