Summary: | Google OAuth auto registration error | ||
---|---|---|---|
Product: | Koha | Reporter: | Maya Das <mydsls> |
Component: | Authentication | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | critical | ||
Priority: | P5 - low | CC: | chris, costalc, dpavlin, jonathan.druart, katrin.fischer, martin.renvoize, nick |
Version: | master | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22777 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.05.00, 18.11.06
|
|
Bug Depends on: | 20287 | ||
Bug Blocks: | |||
Attachments: |
Bug 22717: (bug 20287 follow-up) Fix Google OpenId auto registration
Bug 22717: (bug 20287 follow-up) Fix Google OpenId auto registration |
Description
Maya Das
2019-04-16 17:28:26 UTC
Hi Maya, which exact version of Koha are you using? Created attachment 88974 [details] [review] Bug 22717: (bug 20287 follow-up) Fix Google OpenId auto registration Silly bug caused by: commit ef410fd62f279a10687636a4f26babb2c91ecadc Bug 20287: Replace occurrences of AddMember with Koha::Patron->new->store->borrowernumber Constructors take a hashref! *** Bug 22777 has been marked as a duplicate of this bug. *** Hi Jonathan, I have just test this patch but still fails (same error, internal server error) (In reply to Claudio from comment #4) > Hi Jonathan, I have just test this patch but still fails (same error, > internal server error) Are you sure you restarted plack? Still getting the "Can't use string" error? I'm soooooooo sorry Jonathan, you're right. I restarted plack and all work fine again. Thank you sooooo much for you patience.. If you agree I can sign this bug off. No worries Claudio, thank you for testing! If it works, you can sign it off! Tested! This patch solves the problem. Created attachment 89057 [details] [review] Bug 22717: (bug 20287 follow-up) Fix Google OpenId auto registration Silly bug caused by: commit ef410fd62f279a10687636a4f26babb2c91ecadc Bug 20287: Replace occurrences of AddMember with Koha::Patron->new->store->borrowernumber Constructors take a hashref! Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Awesome work all! Pushed to master for 19.05 Thank You All for this kind effort, the Bug was cause in 18.11.04 -Maya Pushed to 18.11.x for 18.11.06 |