|
Description
Fridolin Somers
2019-04-17 11:57:41 UTC
I had this error with authorities indexing with Elasticsearch Created attachment 88187 [details] [review] Bug 22723: Correct syntax error on confess call in Koha/MetadataRecord/Authority.pm In Koha/MetadataRecord/Authority.pm the call to confess is missing string quotes. It may generates this error : Can't locate object method "confess" via package "Empty String at /usr/share/perl5/MARC/File/XML.pm line 448. " (perhaps you forgot to load "Empty String at /usr/share/perl5/MARC/File/XML.pm line 448. "?) at /home/koha/src/Koha/MetadataRecord/Authority.pm line 186. Simply missing double quotes. I dont know how I could create a test plan but maybe it is not needed. Created attachment 88188 [details] [review] Bug 22723: Correct syntax error on confess call in Koha/MetadataRecord/Authority.pm In Koha/MetadataRecord/Authority.pm the call to confess is missing string quotes. It may generates this error : Can't locate object method "confess" via package "Empty String at /usr/share/perl5/MARC/File/XML.pm line 448. " (perhaps you forgot to load "Empty String at /usr/share/perl5/MARC/File/XML.pm line 448. "?) at /home/koha/src/Koha/MetadataRecord/Authority.pm line 186. Simply missing double quotes. Also missing use Carp to call confess. Created attachment 88616 [details] [review] Bug 22723: Correct syntax error on confess call in Koha/MetadataRecord/Authority.pm In Koha/MetadataRecord/Authority.pm the call to confess is missing string quotes. It may generates this error : Can't locate object method "confess" via package "Empty String at /usr/share/perl5/MARC/File/XML.pm line 448. " (perhaps you forgot to load "Empty String at /usr/share/perl5/MARC/File/XML.pm line 448. "?) at /home/koha/src/Koha/MetadataRecord/Authority.pm line 186. Simply missing double quotes. Also missing use Carp to call confess. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 88689 [details] [review] Bug 22723: Correct syntax error on confess call in Koha/MetadataRecord/Authority.pm In Koha/MetadataRecord/Authority.pm the call to confess is missing string quotes. It may generates this error : Can't locate object method "confess" via package "Empty String at /usr/share/perl5/MARC/File/XML.pm line 448. " (perhaps you forgot to load "Empty String at /usr/share/perl5/MARC/File/XML.pm line 448. "?) at /home/koha/src/Koha/MetadataRecord/Authority.pm line 186. Simply missing double quotes. Also missing use Carp to call confess. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Good catch, Passing QA Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.05 pushed to 18.05.x for 18.05.13 |