Summary: | OverDrive results page is missing overdrive-login include | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | OPAC | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | normal | ||
Priority: | P5 - low | CC: | lucas, martin.renvoize, wizzyrea |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.05.00, 18.11.05
|
|
Circulation function: | |||
Attachments: |
Bug 22743: Add password modal to overdrive results page
Bug 22743: Add password modal to overdrive results page Bug 22743: Add password modal to overdrive results page |
Description
Nick Clemens (kidclamp)
2019-04-19 11:28:08 UTC
Created attachment 88348 [details] [review] Bug 22743: Add password modal to overdrive results page This patch also removes a line abotu ratings which was throwing an error. Confirm stars rating for OD results are still shown as expected To test: 1 - Enable overdrive circulation with password required 2 - Sign in to OPAC but not overdrive 3 - Perform a search that returns overdrive results 4 - Click in to results page http://localhost:8080/cgi-bin/koha/opac-overdrive-search.pl?q=cats 5 - Note 'Login to OverDrive account' link 6 - Click it 7 - Nothing happens! 8 - Apply patch 9 - Repeat 10 - Success! Created attachment 88371 [details] [review] Bug 22743: Add password modal to overdrive results page This patch also removes a line abotu ratings which was throwing an error. Confirm stars rating for OD results are still shown as expected To test: 1 - Enable overdrive circulation with password required 2 - Sign in to OPAC but not overdrive 3 - Perform a search that returns overdrive results 4 - Click in to results page http://localhost:8080/cgi-bin/koha/opac-overdrive-search.pl?q=cats 5 - Note 'Login to OverDrive account' link 6 - Click it 7 - Nothing happens! 8 - Apply patch 9 - Repeat 10 - Success! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Patch reads well, trusting Owen's testing here! Created attachment 88683 [details] [review] Bug 22743: Add password modal to overdrive results page This patch also removes a line abotu ratings which was throwing an error. Confirm stars rating for OD results are still shown as expected To test: 1 - Enable overdrive circulation with password required 2 - Sign in to OPAC but not overdrive 3 - Perform a search that returns overdrive results 4 - Click in to results page http://localhost:8080/cgi-bin/koha/opac-overdrive-search.pl?q=cats 5 - Note 'Login to OverDrive account' link 6 - Click it 7 - Nothing happens! 8 - Apply patch 9 - Repeat 10 - Success! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.05 backported to 18.05.x for 18.05.13 |