Bug 22748

Summary: Wrong permission check in addbiblio.pl
Product: Koha Reporter: Agustín Moyano <agustinmoyano>
Component: Architecture, internals, and plumbingAssignee: Nick Clemens <nick>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: katrin.fischer, martin.renvoize
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
19.05.00
Bug Depends on: 20128    
Bug Blocks: 16232    
Attachments: Bug 22748: Pass uderid to haspermission
Bug 22748: Pass uderid to haspermission
Bug 22748: Pass userid to haspermission

Description Agustín Moyano 2019-04-22 14:35:54 UTC
It calls C4::Auth::haspermission with borrowernumber, when sub requires userid
Comment 1 Nick Clemens 2019-04-22 14:48:06 UTC
Created attachment 88382 [details] [review]
Bug 22748: Pass uderid to haspermission
Comment 2 Agustín Moyano 2019-04-22 15:14:16 UTC
Created attachment 88386 [details] [review]
Bug 22748: Pass uderid to haspermission

Signed-off-by: Agustin Moyano <agustinmoyano@theke.io>
Comment 3 Katrin Fischer 2019-04-24 06:03:58 UTC
Misses a test plan, but looking at the code the change makes sense.
Comment 4 Katrin Fischer 2019-04-24 06:07:08 UTC
Created attachment 88592 [details] [review]
Bug 22748: Pass userid to haspermission

Signed-off-by: Agustin Moyano <agustinmoyano@theke.io>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Nick Clemens 2019-04-24 11:49:12 UTC
Awesome work all!

Pushed to master for 19.05
Comment 6 Martin Renvoize 2019-04-26 14:56:49 UTC
Bug with enhancement not in 18.11.x series.