Summary: | Move hold to top button doesn't work if waiting holds exist | ||
---|---|---|---|
Product: | Koha | Reporter: | Barton Chittenden <barton> |
Component: | Hold requests | Assignee: | Nick Clemens <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | gmcharlt, katrin.fischer, lisettepalouse+koha, lucas, martin.renvoize, nick, wizzyrea |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.05.00, 18.11.05
|
|
Attachments: |
Bug 22753: Fix hold priority adjustment, move to top
Bug 22753: Fix hold priority adjustment, move to top Bug 22753: (QA follow-up) fixing tabs Bug 22753: Fix hold priority adjustment, move to top Bug 22753: Fix tabs pointed out by QA script |
Description
Barton Chittenden
2019-04-22 21:56:40 UTC
Created attachment 88551 [details] [review] Bug 22753: Fix hold priority adjustment, move to top Since the holds table can be split we need to calculate the first priority for each table. However, currently we use the firs tin the loop, not taking into accoutn waiting status. This patchset sets the first_priority to the first non-found hold Additionally, some cleanmup is done to not display the alter priority arrows for waiting holds To test: 1 - Place several holds on a title 2 - Confirm one of the holds to be waiting 3 - Attempt to move the last hold to the top 4 - Nothing happens 5 - Apply patch 6 - Note that the waiting hold has no options to move in the list 7 - Attempt to move the last hold to the top 8 - It moves as expected! 9 - Split the holds queue by pickup library 10 - PLace some holds for pickup at another branch 11 - Confirm moving these holds works within their own table 12 - Unsplit the queue 13 - Ensure the holds end where you expect (moving in a split table didn't move above holds form another table) Created attachment 88555 [details] [review] Bug 22753: Fix hold priority adjustment, move to top Since the holds table can be split we need to calculate the first priority for each table. However, currently we use the firs tin the loop, not taking into accoutn waiting status. This patchset sets the first_priority to the first non-found hold Additionally, some cleanmup is done to not display the alter priority arrows for waiting holds To test: 1 - Place several holds on a title 2 - Confirm one of the holds to be waiting 3 - Attempt to move the last hold to the top 4 - Nothing happens 5 - Apply patch 6 - Note that the waiting hold has no options to move in the list 7 - Attempt to move the last hold to the top 8 - It moves as expected! 9 - Split the holds queue by pickup library 10 - PLace some holds for pickup at another branch 11 - Confirm moving these holds works within their own table 12 - Unsplit the queue 13 - Ensure the holds end where you expect (moving in a split table didn't move above holds form another table) Signed-off-by: Liz Rea <wizzyrea@gmail.com> Created attachment 88556 [details] [review] Bug 22753: (QA follow-up) fixing tabs Created attachment 88641 [details] [review] Bug 22753: Fix hold priority adjustment, move to top Since the holds table can be split we need to calculate the first priority for each table. However, currently we use the first in the loop, not taking into account the waiting status. This patchset sets the first_priority to the first non-found hold Additionally, some clean-up is done to not display the alter priority arrows for waiting holds. To test: 1 - Place several holds on a title 2 - Confirm one of the holds to be waiting 3 - Attempt to move the last hold to the top 4 - Nothing happens 5 - Apply patch 6 - Note that the waiting hold has no options to move in the list 7 - Attempt to move the last hold to the top 8 - It moves as expected! 9 - Split the holds queue by pickup library 10 - PLace some holds for pickup at another branch 11 - Confirm moving these holds works within their own table 12 - Unsplit the queue 13 - Ensure the holds end where you expect (moving in a split table didn't move above holds form another table) Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 88642 [details] [review] Bug 22753: Fix tabs pointed out by QA script Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.05 not necessary in 18.05.x, won't backport |