Summary: | Import Koha::Script to patron_emailer cronjob | ||
---|---|---|---|
Product: | Koha | Reporter: | Josef Moravec <josef.moravec> |
Component: | Architecture, internals, and plumbing | Assignee: | Josef Moravec <josef.moravec> |
Status: | CLOSED FIXED | QA Contact: | Martin Renvoize <martin.renvoize> |
Severity: | normal | ||
Priority: | P5 - low | CC: | martin.renvoize, nick |
Version: | master | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.05.00
|
|
Bug Depends on: | 16149, 22600 | ||
Bug Blocks: | |||
Attachments: |
Bug 22755: Import Koha::Script into patron_emailer cronjob
Bug 22755: Fix pod in patron_emailer.pl Bug 22755: Import Koha::Script into patron_emailer cronjob Bug 22755: Fix pod in patron_emailer.pl |
Description
Josef Moravec
2019-04-23 07:32:31 UTC
Bug 22603 added Koha::Script module to create some userenv when running commands/cronjobs. Patron emailer cronjob from bug 16149 was written before, so it is missing this import. (In reply to Josef Moravec from comment #1) > Bug 22603 added Koha::Script module to create some userenv when running > commands/cronjobs. Patron emailer cronjob from bug 16149 was written before, > so it is missing this import. In fact it was bug 22600, sorry Created attachment 88402 [details] [review] Bug 22755: Import Koha::Script into patron_emailer cronjob Test plan: Run patron_emailer.pl cronjob to ensure it is not broken after this patch Created attachment 88403 [details] [review] Bug 22755: Fix pod in patron_emailer.pl Created attachment 88524 [details] [review] Bug 22755: Import Koha::Script into patron_emailer cronjob Test plan: Run patron_emailer.pl cronjob to ensure it is not broken after this patch Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 88525 [details] [review] Bug 22755: Fix pod in patron_emailer.pl Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Good catch Josef.. going straight for PQA as it's a trivial patch. Also, I'm going to log an issue to add a check for a 'use Koha::Script' statement in the QA tools for anything under /scripts Awesome work all! Pushed to master for 19.05 Dependency not in 18.11.x series. |