Summary: | More YUI grid cleanup | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | katrin.fischer, lucas, martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.05.00
|
|
Bug Depends on: | |||
Bug Blocks: | 20654 | ||
Attachments: |
Bug 22764: More YUI grid cleanup
Bug 22764: More YUI grid cleanup Bug 22764: More YUI grid cleanup Bug 22764: Change marcfield to MARC field in alert message |
Description
Owen Leonard
2019-04-24 13:19:47 UTC
Created attachment 88621 [details] [review] Bug 22764: More YUI grid cleanup This patch cleans up a few places where templates still contain YUI grid markup. Some other minor markup problems are also fixed. - additional-fields.tt: - Converts YUI grid to Bootstrap - Replaces obsolete <tt> tag with styled <span> - Adds _() function to string in embedded JavaScript - detail.tt: - Fixes some stray YUI grid classes - Fixes corresponding JavaScript to enable page adjustments - moredetail.tt: - Removes unnecessary YUI grid markup To test, apply the patch and view the affected pages, confirming that everything looks correct and that the page adjusts well to various browser widthds. When testing the bibliographic detail page, enable AmazonCoverImages and view a record with and without an Amazon cover image. The layout should work in both cases. Created attachment 88674 [details] [review] Bug 22764: More YUI grid cleanup This patch cleans up a few places where templates still contain YUI grid markup. Some other minor markup problems are also fixed. - additional-fields.tt: - Converts YUI grid to Bootstrap - Replaces obsolete <tt> tag with styled <span> - Adds _() function to string in embedded JavaScript - detail.tt: - Fixes some stray YUI grid classes - Fixes corresponding JavaScript to enable page adjustments - moredetail.tt: - Removes unnecessary YUI grid markup To test, apply the patch and view the affected pages, confirming that everything looks correct and that the page adjusts well to various browser widthds. When testing the bibliographic detail page, enable AmazonCoverImages and view a record with and without an Amazon cover image. The layout should work in both cases. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> All these pages look good, at all screen sizes. The details.tt seems clean with or without Amazon cover images and at all screen sizes. (In reply to Lucas Gass from comment #3) > All these pages look good, at all screen sizes. The details.tt seems clean > with or without Amazon cover images and at all screen sizes. Thx for your testing notes! Created attachment 88677 [details] [review] Bug 22764: More YUI grid cleanup This patch cleans up a few places where templates still contain YUI grid markup. Some other minor markup problems are also fixed. - additional-fields.tt: - Converts YUI grid to Bootstrap - Replaces obsolete <tt> tag with styled <span> - Adds _() function to string in embedded JavaScript - detail.tt: - Fixes some stray YUI grid classes - Fixes corresponding JavaScript to enable page adjustments - moredetail.tt: - Removes unnecessary YUI grid markup To test, apply the patch and view the affected pages, confirming that everything looks correct and that the page adjusts well to various browser widthds. When testing the bibliographic detail page, enable AmazonCoverImages and view a record with and without an Amazon cover image. The layout should work in both cases. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 88678 [details] [review] Bug 22764: Change marcfield to MARC field in alert message Also includes a translation and a few capitalization fixes ;) Awesome work all! Pushed to master for 19.05 Enhancement will not be backported to 18.11.x series. |