Summary: | 'Location' not picked up by translation toolchain | ||
---|---|---|---|
Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
Component: | I18N/L10N | Assignee: | Bugs List <koha-bugs> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | f.demians, fridolin.somers, lucas, mtompset |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.11.00,19.11.02
|
|
Circulation function: | |||
Bug Depends on: | 22318 | ||
Bug Blocks: | |||
Attachments: |
Bug 22783: Make 'OPAC News' string translatable
Bug 22783: (follow up) not SET for anonymous BLOCK Bug 22783: Make 'OPAC News' string translatable Bug 22783: (follow up) not SET for anonymous BLOCK Bug 22783: Make 'OPAC News' string translatable Bug 22783: (follow up) not SET for anonymous BLOCK |
Description
Martin Renvoize (ashimema)
2019-04-26 13:50:28 UTC
Suggested fix (also from paxed) is: [% SET location = BLOCK %]OPAC news[% END %] Created attachment 88923 [details] [review] Bug 22783: Make 'OPAC News' string translatable Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Software error: Template process failed: file error - parse error - /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt line 284: unexpected token (BLOCK) [% SET location = BLOCK %] at /home/vagrant/kohaclone/C4/Templates.pm line 122. Same kind of explosion with plack. Created attachment 90674 [details] [review] Bug 22783: (follow up) not SET for anonymous BLOCK Created attachment 90675 [details] [review] Bug 22783: Make 'OPAC News' string translatable The idea was to use an anonymous block Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 90676 [details] [review] Bug 22783: (follow up) not SET for anonymous BLOCK Fixed syntax. http://www.template-toolkit.org/docs/manual/Directives.html#section_BLOCK Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Test plan is to navigate in the staff client to the News Home -> Tools -> News And have at least one item that is in the OPAC News, not NavRight, position. Before and after should be the same, if no translation is done. If translation is done, Opac News can be translated after the patch is applied. Created attachment 90696 [details] [review] Bug 22783: Make 'OPAC News' string translatable The idea was to use an anonymous block Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 90697 [details] [review] Bug 22783: (follow up) not SET for anonymous BLOCK Fixed syntax. http://www.template-toolkit.org/docs/manual/Directives.html#section_BLOCK Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work! Pushed to master for 19.11.00 Pushed to 19.05.x for 19.05.02 missing dependency for 18.11.x series, no backport |