Summary: | Set dataTable width issue | ||
---|---|---|---|
Product: | Koha | Reporter: | Arthur Suzuki <arthur.suzuki> |
Component: | OPAC | Assignee: | Arthur Suzuki <arthur.suzuki> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | m.de.rooy, martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.05.00
|
|
Circulation function: | |||
Bug Depends on: | 11976 | ||
Bug Blocks: | |||
Attachments: |
Bug 22803: Fix dataTable width
Shrinked subscription table Bug 22803: (alternate) Set dataTable width issue Bug 22803: (alternate) Set dataTable width issue Bug 22803: (alternate) Set dataTable width issue |
Description
Arthur Suzuki
2019-04-29 14:12:58 UTC
Created attachment 89011 [details] [review] Bug 22803: Fix dataTable width Test plan : 1 - Go to Administration / Configure columns 2 - check Opac/serial_notes "is hidden by defaut" 3 - search a serials on the opac and in the opac-details page, subscriptions tab, find out that the table is shrinked on the left 4 - Apply patch 5 - Find out subscription table fills the tab correctly Could you add a screeshot showing the problem? I don't think I'm seeing the problem. I'm hoping there might be another way to fix it. Adding an "!important" rule is not ideal. Created attachment 89016 [details]
Shrinked subscription table
Created attachment 89035 [details] [review] Bug 22803: (alternate) Set dataTable width issue This patch sets the "autowidth" option to "false" for the OPAC subscriptions DataTable on opac-detail.pl. This gives the table a fluid width rather than having the width be "hard-coded" by DataTables upon first page render. To test, apply the patch and view the detail page for a bibliographic record with a subscription. Under the "Subscriptions" tab, the table of latest issues should fill the width of the tab container. Resize the browser window and confirm that the table width adjusts accordingly. I'm proposing an alternate solution. I think this is the correct way to deal with it within the options provided by DataTables. The "autowidth" option should probably be set to "false" globally. Created attachment 89157 [details] [review] Bug 22803: (alternate) Set dataTable width issue This patch sets the "autowidth" option to "false" for the OPAC subscriptions DataTable on opac-detail.pl. This gives the table a fluid width rather than having the width be "hard-coded" by DataTables upon first page render. To test, apply the patch and view the detail page for a bibliographic record with a subscription. Under the "Subscriptions" tab, the table of latest issues should fill the width of the tab container. Resize the browser window and confirm that the table width adjusts accordingly. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Created attachment 89301 [details] [review] Bug 22803: (alternate) Set dataTable width issue This patch sets the "autowidth" option to "false" for the OPAC subscriptions DataTable on opac-detail.pl. This gives the table a fluid width rather than having the width be "hard-coded" by DataTables upon first page render. To test, apply the patch and view the detail page for a bibliographic record with a subscription. Under the "Subscriptions" tab, the table of latest issues should fill the width of the tab container. Resize the browser window and confirm that the table width adjusts accordingly. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Awesome work all! Pushed to master for 19.05 Enhancement will not be backported to 18.11.x series. |