Summary: | OPAC detail holdings table doesn't fill it's container | ||
---|---|---|---|
Product: | Koha | Reporter: | Liz Rea <wizzyrea> |
Component: | OPAC | Assignee: | Liz Rea <wizzyrea> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | arthur.bousquet, lucas, nick, wizzyrea |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.05.00, 18.11.06
|
|
Circulation function: | |||
Attachments: |
Bug 22816: OPAC detail holdings table should now look a bit better
Bug 22816: OPAC detail holdings table should now look a bit better Bug 22816: OPAC detail holdings table should now look a bit better Bug 22816: OPAC detail holdings table should now look a bit better |
Description
Liz Rea
2019-05-01 00:28:25 UTC
Created attachment 89158 [details] [review] Bug 22816: OPAC detail holdings table should now look a bit better This patch sets the "autowidth" option to "false" for the OPAC holdings DataTable on opac-detail.pl. This gives the table a fluid width rather than having the width be "hard-coded" by DataTables upon first page render. To test, apply the patch and view the detail page for a bibliographic record with some items. Under the "Holdings" tab, the table of holdings should fill the width of the tab container. Resize the browser window and confirm that the table width adjusts accordingly. thanks to Owen Leonard for the initial fix for the subscriptions table and the test plan. Created attachment 89326 [details] [review] Bug 22816: OPAC detail holdings table should now look a bit better This patch sets the "autowidth" option to "false" for the OPAC holdings DataTable on opac-detail.pl. This gives the table a fluid width rather than having the width be "hard-coded" by DataTables upon first page render. To test, apply the patch and view the detail page for a bibliographic record with some items. Under the "Holdings" tab, the table of holdings should fill the width of the tab container. Resize the browser window and confirm that the table width adjusts accordingly. Signed-off-by: Bin Wen <bin.wen@inlibro.com> Created attachment 89328 [details] [review] Bug 22816: OPAC detail holdings table should now look a bit better This patch sets the "autowidth" option to "false" for the OPAC holdings DataTable on opac-detail.pl. This gives the table a fluid width rather than having the width be "hard-coded" by DataTables upon first page render. To test, apply the patch and view the detail page for a bibliographic record with some items. Under the "Holdings" tab, the table of holdings should fill the width of the tab container. Resize the browser window and confirm that the table width adjusts accordingly. Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: arthur <arthur.bousquet@inlibro.com> The bug isn't present in Firefox 67.0b16 but is in Chrome 74.0.3729.131 The patch works for this version of Chrome an doesn't change anything in Firefox Created attachment 89351 [details] [review] Bug 22816: OPAC detail holdings table should now look a bit better This patch sets the "autowidth" option to "false" for the OPAC holdings DataTable on opac-detail.pl. This gives the table a fluid width rather than having the width be "hard-coded" by DataTables upon first page render. To test, apply the patch and view the detail page for a bibliographic record with some items. Under the "Holdings" tab, the table of holdings should fill the width of the tab container. Resize the browser window and confirm that the table width adjusts accordingly. Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: arthur <arthur.bousquet@inlibro.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.06 backported to 18.05.x for 18.05.13 |